src/utils/SkDashPath.cpp - Issue 1503423003: ubsan shift fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/SkDashPath.cpp

Issue 1503423003: ubsan shift fixes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add cast to work around win compiler Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/SkDashPath.cpp

diff --git a/src/utils/SkDashPath.cpp b/src/utils/SkDashPath.cpp

index e0cbe9732d24f1ce888e80abe8708851246cec8e..4e34b87eac1b09cb71b20b665ede3de2ed293155 100644

--- a/src/utils/SkDashPath.cpp

+++ b/src/utils/SkDashPath.cpp

@@ -10,7 +10,7 @@

#include "SkStrokeRec.h"

static inline int is_even(int x) {

- return (~x) << 31;

+ return !(x & 1);

}

static SkScalar find_first_interval(const SkScalar intervals[], SkScalar phase,

« no previous file with comments | « src/ports/SkFontMgr_android_parser.h ('k') | tests/MathTest.cpp » ('j') | no next file with comments »