src/pathops/SkOpAngle.cpp - Issue 1503423003: ubsan shift fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pathops/SkOpAngle.cpp

Issue 1503423003: ubsan shift fixes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add cast to work around win compiler Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pathops/SkOpAngle.cpp

diff --git a/src/pathops/SkOpAngle.cpp b/src/pathops/SkOpAngle.cpp

index 655df45b15fa16edf91881f39741be605937cc62..c2eb0c93266212360fb5f2550ffd7e13ee0880cc 100644

--- a/src/pathops/SkOpAngle.cpp

+++ b/src/pathops/SkOpAngle.cpp

@@ -1016,7 +1016,7 @@ deferTilLater:

if (!crossesZero) {

fSectorMask = (unsigned) -1 >> (31 - end + start) << start;

} else {

- fSectorMask = (unsigned) -1 >> (31 - start) | (-1 << end);

+ fSectorMask = (unsigned) -1 >> (31 - start) | ((unsigned) -1 << end);

}

« no previous file with comments | « src/images/SkImageDecoder_libico.cpp ('k') | src/ports/SkFontMgr_android_parser.h » ('j') | no next file with comments »