src/core/SkScan_Antihair.cpp - Issue 1503423003: ubsan shift fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkScan_Antihair.cpp

Issue 1503423003: ubsan shift fixes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add cast to work around win compiler Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkScan_Antihair.cpp

diff --git a/src/core/SkScan_Antihair.cpp b/src/core/SkScan_Antihair.cpp

index b14e12bab8c8d3157ae37ec73d3b67ca2e3c2d43..8ee0ba5f98334c0be7fd52729c0bf4ce1db0c4d0 100644

--- a/src/core/SkScan_Antihair.cpp

+++ b/src/core/SkScan_Antihair.cpp

@@ -250,9 +250,9 @@ public:

};

static inline SkFixed fastfixdiv(SkFDot6 a, SkFDot6 b) {

- SkASSERT((a << 16 >> 16) == a);

+ SkASSERT((SkLeftShift(a, 16) >> 16) == a);

SkASSERT(b != 0);

- return (a << 16) / b;

+ return SkLeftShift(a, 16) / b;

}

#define SkBITCOUNT(x) (sizeof(x) << 3)

« no previous file with comments | « src/core/SkScan_AntiPath.cpp ('k') | src/core/SkScan_Path.cpp » ('j') | no next file with comments »