src/core/SkEdge.h - Issue 1503423003: ubsan shift fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkEdge.h

Issue 1503423003: ubsan shift fixes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add cast to work around win compiler Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkEdge.h

diff --git a/src/core/SkEdge.h b/src/core/SkEdge.h

index db6f43085dadf88bd4b28cd128a2280d86935d92..c3adbf85cb2d83afe54ee31f10330960e435fb93 100644

--- a/src/core/SkEdge.h

+++ b/src/core/SkEdge.h

@@ -15,7 +15,7 @@

#include "SkMath.h"

// This correctly favors the lower-pixel when y0 is on a 1/2 pixel boundary

-#define SkEdge_Compute_DY(top, y0) ((top << 6) + 32 - (y0))

+#define SkEdge_Compute_DY(top, y0) (SkLeftShift(top, 6) + 32 - (y0))

struct SkEdge {

enum Type {

« no previous file with comments | « src/core/SkBitmapProcState_matrixProcs.cpp ('k') | src/core/SkEdge.cpp » ('j') | no next file with comments »