tests/MathTest.cpp - Issue 1503423003: ubsan shift fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/MathTest.cpp

Issue 1503423003: ubsan shift fixes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/MathTest.cpp

diff --git a/tests/MathTest.cpp b/tests/MathTest.cpp

index 3c2bc644073ddcd211e732c645a28fd894a4b00d..e6419611fe1570e7de5b37795919b785effd394f 100644

--- a/tests/MathTest.cpp

+++ b/tests/MathTest.cpp

@@ -561,7 +561,7 @@ DEF_TEST(Math, reporter) {

SkFixed numer = rand.nextS();

SkFixed denom = rand.nextS();

SkFixed result = SkFixedDiv(numer, denom);

- int64_t check = ((int64_t)numer << 16) / denom;

+ int64_t check = (int64_t)numer * (1 << 16) / denom;

(void)SkCLZ(numer);

(void)SkCLZ(denom);