src/ports/SkFontMgr_android_parser.h - Issue 1503423003: ubsan shift fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontMgr_android_parser.h

Issue 1503423003: ubsan shift fixes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontMgr_android_parser.h

diff --git a/src/ports/SkFontMgr_android_parser.h b/src/ports/SkFontMgr_android_parser.h

index aca1573952d17f4237387847c8dc35d68fe8bf4b..19b58607af47efab7d18e38e897f856feb3e7157 100644

--- a/src/ports/SkFontMgr_android_parser.h

+++ b/src/ports/SkFontMgr_android_parser.h

@@ -211,7 +211,7 @@ template <int N, typename T> static bool parse_fixed(const char* s, T* value) {

n = -n;

frac = -frac;

}

- *value = (n << N) + frac;

+ *value = n * (1 << N) + frac;

return true;

}