src/core/SkScan_Path.cpp - Issue 1503423003: ubsan shift fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkScan_Path.cpp

Issue 1503423003: ubsan shift fixes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkScan_Path.cpp

diff --git a/src/core/SkScan_Path.cpp b/src/core/SkScan_Path.cpp

index fc79fc8537d08fdbff306ee801a2fa66a5a9a6a2..3666f57916e0bcc88236e88d1871182a82d8e579 100644

--- a/src/core/SkScan_Path.cpp

+++ b/src/core/SkScan_Path.cpp

@@ -450,8 +450,8 @@ void sk_fill_path(const SkPath& path, const SkIRect* clipRect, SkBlitter* blitte

// now edge is the head of the sorted linklist

- start_y <<= shiftEdgesUp;

- stop_y <<= shiftEdgesUp;

+ start_y *= 1 << shiftEdgesUp;

+ stop_y *= 1 << shiftEdgesUp;

if (clipRect && start_y < clipRect->fTop) {

start_y = clipRect->fTop;

}