src/core/SkMath.cpp - Issue 1503423003: ubsan shift fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkMath.cpp

Issue 1503423003: ubsan shift fixes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkMath.cpp

diff --git a/src/core/SkMath.cpp b/src/core/SkMath.cpp

index af93d7ecb2cf850f00745c01783ca123621606e4..57b27408dfe94b9b61727cacb1bb1378fcf697cc 100644

--- a/src/core/SkMath.cpp

+++ b/src/core/SkMath.cpp

@@ -72,8 +72,8 @@ int32_t SkDivBits(int32_t numer, int32_t denom, int shift_bias) {

return SkApplySign(SK_MaxS32, sign);

}

- denom <<= dbits;

- numer <<= nbits;

+ denom *= 1 << dbits;

+ numer *= 1 << nbits;

SkFixed result = 0;