ubsan shift fixes

src/core/SkFloatBits.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkFloatBits.h"
 #include "SkMathPriv.h"
 
@@ skipping 47 matching lines @@
             exp = 25;
         }
         value >>= exp;
     }
     return SkApplySign(value, SkExtractSign(packed));
 }
 
 // same as (int)floor(float)
 int32_t SkFloatBits_toIntFloor(int32_t packed) {
     // curse you negative 0
-    if ((packed << 1) == 0) {
+    if (SkLeftShift(packed, 1) == 0) {
         return 0;
     }
 
     int exp = unpack_exp(packed) - EXP_BIAS;
     int value = unpack_matissa_dirty(packed) | MATISSA_MAGIC_BIG;
 
     if (exp >= 0) {
         if (exp > 7) {    // overflow
             value = SK_MaxS32;
         } else {
@@ skipping 18 matching lines @@
 #endif
         }
         // int add = 0;
         return value >> exp;
     }
 }
 
 // same as (int)floor(float + 0.5)
 int32_t SkFloatBits_toIntRound(int32_t packed) {
     // curse you negative 0
-    if ((packed << 1) == 0) {
+    if (SkLeftShift(packed, 1) == 0) {
         return 0;
     }
 
     int exp = unpack_exp(packed) - EXP_BIAS;
     int value = unpack_matissa_dirty(packed) | MATISSA_MAGIC_BIG;
 
     if (exp >= 0) {
         if (exp > 7) {    // overflow
             value = SK_MaxS32;
         } else {
             value <<= exp;
         }
         // apply the sign after we check for overflow
         return SkApplySign(value, SkExtractSign(packed));
     } else {
         // apply the sign before we right-shift
         value = SkApplySign(value, SkExtractSign(packed));
         exp = -exp;
         if (exp > 25) {   // underflow
             exp = 25;
         }
         int add = 1 << (exp - 1);
         return (value + add) >> exp;
     }
 }
 
 // same as (int)ceil(float)
 int32_t SkFloatBits_toIntCeil(int32_t packed) {
     // curse you negative 0
-    if ((packed << 1) == 0) {
+    if (SkLeftShift(packed, 1) == 0) {
         return 0;
     }
 
     int exp = unpack_exp(packed) - EXP_BIAS;
     int value = unpack_matissa_dirty(packed) | MATISSA_MAGIC_BIG;
 
     if (exp >= 0) {
         if (exp > 7) {    // overflow
             value = SK_MaxS32;
         } else {
@@ skipping 45 matching lines @@
         SkASSERT(zeros >= 0 && zeros <= 23);
         value <<= zeros;
         shift -= zeros;
     }
 
     // now value is left-aligned to 24 bits
     SkASSERT((value >> 23) == 1);
     SkASSERT(shift >= 0 && shift <= 255);
 
     SkFloatIntUnion data;
-    data.fSignBitInt = (sign << 31) | (shift << 23) | (value & ~MATISSA_MAGIC_BIG);
+    data.fSignBitInt = SkLeftShift(sign, 31) | SkLeftShift(shift, 23) | (value & ~MATISSA_MAGIC_BIG);
     return data.fFloat;
 }