chrome/browser/resources/settings/basic_page/basic_page.html - Issue 1503403004: Settings People Rewrite: Move users_page as subpage of People.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.html

Issue 1503403004: Settings People Rewrite: Move users_page as subpage of People. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0053-people-rename-a-bunch-of-stuff

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/people_page.html » ('j') | chrome/browser/resources/settings/settings_page/settings_router.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/basic_page/basic_page.html

diff --git a/chrome/browser/resources/settings/basic_page/basic_page.html b/chrome/browser/resources/settings/basic_page/basic_page.html

index 9103cf706fa912bd6006bcc3d844096d8e96f12b..496f9d4e8cefab5347bc0a9dd3e3ae55ff5ea825 100644

--- a/chrome/browser/resources/settings/basic_page/basic_page.html

+++ b/chrome/browser/resources/settings/basic_page/basic_page.html

@@ -7,7 +7,6 @@

-<link rel="import" href="chrome://md-settings/users_page/users_page.html">

</if>

@@ -19,7 +18,7 @@

<settings-section i18n-values="page-title:peoplePageTitle"

current-route="[[currentRoute]]" section="people">

- <settings-people-page current-route="{{currentRoute}}">

+ <settings-people-page prefs="{{prefs}}" current-route="{{currentRoute}}">

</settings-people-page>

</settings-section>

@@ -49,13 +48,6 @@

</settings-search-page>

</settings-section>

-<if expr="chromeos">

- <settings-section i18n-values="page-title:usersPageTitle"

- current-route="[[currentRoute]]" section="users">

- <settings-users-page prefs="{{prefs}}"></settings-users-page>

- </settings-section>

-</if>

<settings-section i18n-values="page-title:defaultBrowser"

expand-container="{{expandContainer}}"