Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 1503403004: Settings People Rewrite: Move users_page as subpage of People. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0053-people-rename-a-bunch-of-stuff
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-router' is a simple router for settings. Its responsibilities: 7 * 'settings-router' is a simple router for settings. Its responsibilities:
8 * - Update the URL when the routing state changes. 8 * - Update the URL when the routing state changes.
9 * - Initialize the routing state with the initial URL. 9 * - Initialize the routing state with the initial URL.
10 * - Process and validate all routing state changes. 10 * - Process and validate all routing state changes.
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 subpage: ['search-engines', 'search-engines-advanced'], 111 subpage: ['search-engines', 'search-engines-advanced'],
112 subpageTitles: ['searchEnginesPageTitle', 'advancedPageTitle'], 112 subpageTitles: ['searchEnginesPageTitle', 'advancedPageTitle'],
113 }, 113 },
114 { 114 {
115 url: '/syncSetup', 115 url: '/syncSetup',
116 page: 'basic', 116 page: 'basic',
117 section: 'people', 117 section: 'people',
118 subpage: ['sync'], 118 subpage: ['sync'],
119 subpageTitles: ['syncPageTitle'], 119 subpageTitles: ['syncPageTitle'],
120 }, 120 },
121 <if expr="chromeos">
122 {
123 url: '/accounts',
124 page: 'basic',
125 section: 'people',
126 subpage: ['users'],
127 subpageTitles: ['usersPageTitle'],
128 },
129 </if>
121 { 130 {
122 url: '/certificates', 131 url: '/certificates',
123 page: 'advanced', 132 page: 'advanced',
124 section: 'privacy', 133 section: 'privacy',
125 subpage: ['manage-certificates'], 134 subpage: ['manage-certificates'],
126 subpageTitles: ['manageCertificates'], 135 subpageTitles: ['manageCertificates'],
127 }, 136 },
128 { 137 {
129 url: '/content', 138 url: '/content',
130 page: 'advanced', 139 page: 'advanced',
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 history.replaceState(historicState, null); 243 history.replaceState(historicState, null);
235 } 244 }
236 245
237 return; 246 return;
238 } 247 }
239 } 248 }
240 249
241 assertNotReached('Route not found: ' + JSON.stringify(newRoute)); 250 assertNotReached('Route not found: ' + JSON.stringify(newRoute));
242 }, 251 },
243 }); 252 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698