Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 1503403004: Settings People Rewrite: Move users_page as subpage of People. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0053-people-rename-a-bunch-of-stuff
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-router' is a simple router for settings. Its responsibilities: 7 * 'settings-router' is a simple router for settings. Its responsibilities:
8 * - Update the URL when the routing state changes. 8 * - Update the URL when the routing state changes.
9 * - Initialize the routing state with the initial URL. 9 * - Initialize the routing state with the initial URL.
10 * - Process and validate all routing state changes. 10 * - Process and validate all routing state changes.
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 subpageTitles: ['searchEnginesPageTitle', 'advancedPageTitle'], 119 subpageTitles: ['searchEnginesPageTitle', 'advancedPageTitle'],
120 }, 120 },
121 { 121 {
122 url: '/syncSetup', 122 url: '/syncSetup',
123 page: 'basic', 123 page: 'basic',
124 section: 'people', 124 section: 'people',
125 subpage: ['sync'], 125 subpage: ['sync'],
126 subpageTitles: ['syncPageTitle'], 126 subpageTitles: ['syncPageTitle'],
127 }, 127 },
128 { 128 {
129 url: '/accounts',
130 page: 'basic',
131 section: 'people',
132 subpage: ['users'],
133 subpageTitles: ['usersPageTitle'],
dschuyler 2015/12/10 00:47:50 Is this a chromeos only page?
tommycli 2015/12/10 02:03:40 Done. Thanks nice catch.
134 },
135 {
129 url: '/certificates', 136 url: '/certificates',
130 page: 'advanced', 137 page: 'advanced',
131 section: 'privacy', 138 section: 'privacy',
132 subpage: ['manage-certificates'], 139 subpage: ['manage-certificates'],
133 subpageTitles: ['manageCertificates'], 140 subpageTitles: ['manageCertificates'],
134 }, 141 },
135 { 142 {
136 url: '/content', 143 url: '/content',
137 page: 'advanced', 144 page: 'advanced',
138 section: 'privacy', 145 section: 'privacy',
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 history.replaceState(historicState, null); 248 history.replaceState(historicState, null);
242 } 249 }
243 250
244 return; 251 return;
245 } 252 }
246 } 253 }
247 254
248 assertNotReached('Route not found: ' + JSON.stringify(newRoute)); 255 assertNotReached('Route not found: ' + JSON.stringify(newRoute));
249 }, 256 },
250 }); 257 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698