Settings People Rewrite: Move users_page as subpage of People.

Settings People Rewrite: Move users_page as subpage of People.

The user list control is a ChromeOS-only page that should be a subpage
of the new People section. (According to my understanding of the mocks.)

BUG=563721
Committed: https://crrev.com/42489fe984797b7096684f09d7232831634cbf8a
Cr-Commit-Position: refs/heads/master@{#364784}

[tommycli, 2015-12-08 23:53:10]

tommycli@chromium.org changed reviewers:
+ dschuyler@chromium.org

[tommycli, 2015-12-08 23:53:11]

dschuyler: PTAL. No rush. This is a follow-up to
https://codereview.chromium.org/1503333003/

[dschuyler, 2015-12-10 00:47:50]

https://codereview.chromium.org/1503403004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_router.js (right):

https://codereview.chromium.org/1503403004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_router.js:133:
subpageTitles: ['usersPageTitle'],
Is this a chromeos only page?

[tommycli, 2015-12-10 02:03:40]

dschuyler: thanks!

https://codereview.chromium.org/1503403004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_router.js (right):

https://codereview.chromium.org/1503403004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_router.js:133:
subpageTitles: ['usersPageTitle'],
On 2015/12/10 00:47:50, dschuyler wrote:
> Is this a chromeos only page?

Done. Thanks nice catch.

[dschuyler, 2015-12-10 17:55:59]

lgtm

[tommycli, 2015-12-10 23:13:38]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2015-12-10 23:13:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/1503403004/#ps60001
(title: "Merge")

[commit-bot: I haz the power, 2015-12-10 23:15:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1503403004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1503403004/60001

[commit-bot: I haz the power, 2015-12-11 00:31:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-11 00:31:38]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2015-12-11 18:32:15]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2015-12-11 18:32:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/1503403004/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-12-11 18:33:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1503403004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1503403004/80001

[commit-bot: I haz the power, 2015-12-11 20:09:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-11 20:10:42]

Description was changed from

==========
Settings People Rewrite: Move users_page as subpage of People.

The user list control is a ChromeOS-only page that should be a subpage
of the new People section. (According to my understanding of the mocks.)

BUG=563721
==========

to

==========
Settings People Rewrite: Move users_page as subpage of People.

The user list control is a ChromeOS-only page that should be a subpage
of the new People section. (According to my understanding of the mocks.)

BUG=563721

Committed: https://crrev.com/42489fe984797b7096684f09d7232831634cbf8a
Cr-Commit-Position: refs/heads/master@{#364784}
==========

[commit-bot: I haz the power, 2015-12-11 20:10:43]

Patchset 5 (id:??) landed as
https://crrev.com/42489fe984797b7096684f09d7232831634cbf8a
Cr-Commit-Position: refs/heads/master@{#364784}