Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: snapshot/win/process_reader_win.cc

Issue 1503403003: win: Fix a few sign mismatch warnings in crashpad. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | util/win/exception_handler_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/win/process_reader_win.cc
diff --git a/snapshot/win/process_reader_win.cc b/snapshot/win/process_reader_win.cc
index 373124d61930f04e3fed8c82f6f0735362eaef7f..f3b632376a8b534672cbff5cfb72218818e83bf9 100644
--- a/snapshot/win/process_reader_win.cc
+++ b/snapshot/win/process_reader_win.cc
@@ -136,7 +136,7 @@ bool FillThreadContextAndSuspendCount(HANDLE thread_handle,
CaptureContext(&thread->context.native);
} else {
DWORD previous_suspend_count = SuspendThread(thread_handle);
- if (previous_suspend_count == -1) {
+ if (previous_suspend_count == static_cast<DWORD>(-1)) {
Mark Mentovai 2015/12/08 22:05:59 -1u?
Nico 2015/12/08 22:07:12 MSDN says that SuspendThread returns "(DWORD)-1" o
PLOG(ERROR) << "SuspendThread";
return false;
}
« no previous file with comments | « no previous file | util/win/exception_handler_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698