Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1503403003: win: Fix a few sign mismatch warnings in crashpad. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
Mark Mentovai, scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad.git@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M snapshot/win/process_reader_win.cc View 1 chunk +1 line, -1 line 2 comments Download
M util/win/exception_handler_server.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Nico
5 years ago (2015-12-08 21:58:01 UTC) #2
Mark Mentovai
https://codereview.chromium.org/1503403003/diff/1/snapshot/win/process_reader_win.cc File snapshot/win/process_reader_win.cc (right): https://codereview.chromium.org/1503403003/diff/1/snapshot/win/process_reader_win.cc#newcode139 snapshot/win/process_reader_win.cc:139: if (previous_suspend_count == static_cast<DWORD>(-1)) { -1u?
5 years ago (2015-12-08 22:05:59 UTC) #4
scottmg
lgtm
5 years ago (2015-12-08 22:06:00 UTC) #6
Nico
https://codereview.chromium.org/1503403003/diff/1/snapshot/win/process_reader_win.cc File snapshot/win/process_reader_win.cc (right): https://codereview.chromium.org/1503403003/diff/1/snapshot/win/process_reader_win.cc#newcode139 snapshot/win/process_reader_win.cc:139: if (previous_suspend_count == static_cast<DWORD>(-1)) { On 2015/12/08 22:05:59, Mark ...
5 years ago (2015-12-08 22:07:12 UTC) #7
Mark Mentovai
OK, LGTM too
5 years ago (2015-12-08 22:09:41 UTC) #9
Nico
Looks like I don't have commit permissions. Please land. error: failed to push some refs ...
5 years ago (2015-12-08 22:20:26 UTC) #10
scottmg
5 years ago (2015-12-08 22:21:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b9e732d3180f9eadc74d7229090e613d0700b8a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698