GpuMemoryBuffers: Tighten AcquireIOSurface's error checking

GpuMemoryBuffers: Tighten AcquireIOSurface's error checking

The function AcquireIOSurface accounts for most of the situations where
GpuMemoryBuffer allocation fails.

Add a CHECK that mach_port_allocate succeeds, because there is no
recovery for being out of resources in this way.

Add a CHECK that, if the browser returns Mach port, that port is valid
can be successfully opened as an IOSurface. This should never be hit,
because the browser should return a valid port if it reports success.

Add a CHECK that mach_msg succeed. The suspicion is that this will
account for all failures of AcquireIOSurface (and that this particular
part of the patch will need to be reverted due to high crash rates).

BUG=554541
Committed: https://crrev.com/efeb58b686b4c9531ce334f0adc34c8cd13ec78b
Cr-Commit-Position: refs/heads/master@{#364432}

[ccameron, 2015-12-08 21:39:36]

Description was changed from

==========
GpuMemoryBuffers: Tighten AcquireIOSurface's error checking

The function AcquireIOSurface accounts for most of the situations where
GpuMemoryBuffer allocation fails.

Add a CHECK that mach_port_allocate succeeds, because there is no
recovery for being out of resources in this way.

Add a CHECK that, if the browser returns Mach port, that port is valid
can be successfully opened as an IOSurface. This should never happen.

Add a CHECK that mach_msg succeed. The suspicion is that this will
account for all failures of AcquireIOSurface (and that this particular
part of the patch will need to be reverted due to high crash rates).

BUG=554541
==========

to

==========
GpuMemoryBuffers: Tighten AcquireIOSurface's error checking

The function AcquireIOSurface accounts for most of the situations where
GpuMemoryBuffer allocation fails.

Add a CHECK that mach_port_allocate succeeds, because there is no
recovery for being out of resources in this way.

Add a CHECK that, if the browser returns Mach port, that port is valid
can be successfully opened as an IOSurface. This should never be hit,
because the browser should return a valid port if it reports success.

Add a CHECK that mach_msg succeed. The suspicion is that this will
account for all failures of AcquireIOSurface (and that this particular
part of the patch will need to be reverted due to high crash rates).

BUG=554541
==========

[ccameron, 2015-12-08 21:39:36]

ccameron@chromium.org changed reviewers:
+ reveman@chromium.org

[ccameron, 2015-12-08 21:41:12]

This is to diagnose what was happening in
ChildIOSurfaceManager::AcquireIOSurface.

That function accounted for 85% of the AllocateGpuMemoryBuffer failures on Mac.
My suspicion is that all of the new crashes will be in mach_msg (because of the
process going down).

[reveman, 2015-12-08 22:03:46]

lgtm but can you add a comment with a bug number that make it clear that this is
just temporary to diagnose allocation errors? maybe even keep the old if
statements to make it more clear that those are needed to safely use this in the
gpu process.

[ccameron, 2015-12-10 01:34:53]

ccameron@chromium.org changed reviewers:
+ avi@chromium.org

[ccameron, 2015-12-10 01:34:53]

Thanks. Adding avi@ for Mac content/ review.

This is more of the (1) "Make OOMs fail close to the point of failure" and (2)
"Try to diagnose why allocations are failing".

[Avi (use Gerrit), 2015-12-10 15:26:48]

lgtm

[ccameron, 2015-12-10 18:59:08]

Thanks!

[ccameron, 2015-12-10 18:59:12]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2015-12-10 18:59:12]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/1503393006/#ps20001
(title: "Add comment")

[commit-bot: I haz the power, 2015-12-10 18:59:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1503393006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1503393006/20001

[commit-bot: I haz the power, 2015-12-10 19:43:41]

Description was changed from

==========
GpuMemoryBuffers: Tighten AcquireIOSurface's error checking

The function AcquireIOSurface accounts for most of the situations where
GpuMemoryBuffer allocation fails.

Add a CHECK that mach_port_allocate succeeds, because there is no
recovery for being out of resources in this way.

Add a CHECK that, if the browser returns Mach port, that port is valid
can be successfully opened as an IOSurface. This should never be hit,
because the browser should return a valid port if it reports success.

Add a CHECK that mach_msg succeed. The suspicion is that this will
account for all failures of AcquireIOSurface (and that this particular
part of the patch will need to be reverted due to high crash rates).

BUG=554541
==========

to

==========
GpuMemoryBuffers: Tighten AcquireIOSurface's error checking

The function AcquireIOSurface accounts for most of the situations where
GpuMemoryBuffer allocation fails.

Add a CHECK that mach_port_allocate succeeds, because there is no
recovery for being out of resources in this way.

Add a CHECK that, if the browser returns Mach port, that port is valid
can be successfully opened as an IOSurface. This should never be hit,
because the browser should return a valid port if it reports success.

Add a CHECK that mach_msg succeed. The suspicion is that this will
account for all failures of AcquireIOSurface (and that this particular
part of the patch will need to be reverted due to high crash rates).

BUG=554541
==========

[commit-bot: I haz the power, 2015-12-10 19:43:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-10 19:45:23]

Description was changed from

==========
GpuMemoryBuffers: Tighten AcquireIOSurface's error checking

The function AcquireIOSurface accounts for most of the situations where
GpuMemoryBuffer allocation fails.

Add a CHECK that mach_port_allocate succeeds, because there is no
recovery for being out of resources in this way.

Add a CHECK that, if the browser returns Mach port, that port is valid
can be successfully opened as an IOSurface. This should never be hit,
because the browser should return a valid port if it reports success.

Add a CHECK that mach_msg succeed. The suspicion is that this will
account for all failures of AcquireIOSurface (and that this particular
part of the patch will need to be reverted due to high crash rates).

BUG=554541
==========

to

==========
GpuMemoryBuffers: Tighten AcquireIOSurface's error checking

The function AcquireIOSurface accounts for most of the situations where
GpuMemoryBuffer allocation fails.

Add a CHECK that mach_port_allocate succeeds, because there is no
recovery for being out of resources in this way.

Add a CHECK that, if the browser returns Mach port, that port is valid
can be successfully opened as an IOSurface. This should never be hit,
because the browser should return a valid port if it reports success.

Add a CHECK that mach_msg succeed. The suspicion is that this will
account for all failures of AcquireIOSurface (and that this particular
part of the patch will need to be reverted due to high crash rates).

BUG=554541

Committed: https://crrev.com/efeb58b686b4c9531ce334f0adc34c8cd13ec78b
Cr-Commit-Position: refs/heads/master@{#364432}
==========

[commit-bot: I haz the power, 2015-12-10 19:45:24]

Patchset 2 (id:??) landed as
https://crrev.com/efeb58b686b4c9531ce334f0adc34c8cd13ec78b
Cr-Commit-Position: refs/heads/master@{#364432}