Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1503353002: Embedded option processing fixes (#25115). (Closed)

Created:
5 years ago by pquitslund
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Embedded option processing fixes (#25115). * Updates error filter and linter configuration to play nice with embedded options. * Fixes embedded lint config (#25115). * Improves support for (and tests of) options file deletions. * Pulls in linter with untyped options support (needed for processing merged options). Unblocks: https://github.com/flutter/flutter/issues/624. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/1e4cea355f6eddf5b39609f5351d63ba21bf6e9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -75 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 3 chunks +23 lines, -20 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 11 chunks +169 lines, -45 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 3 chunks +30 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
5 years ago (2015-12-07 23:32:31 UTC) #2
Brian Wilkerson
LGTM
5 years ago (2015-12-08 00:12:58 UTC) #3
pquitslund
5 years ago (2015-12-08 00:18:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e4cea355f6eddf5b39609f5351d63ba21bf6e9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698