chrome/browser/resources/settings/basic_page/basic_page.html - Issue 1503333003: Settings People Rewrite: Make Sync/Sign-in naming consistent to People.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.html

Issue 1503333003: Settings People Rewrite: Make Sync/Sign-in naming consistent to People. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix an egreious git cl format error Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/people_page/compiled_resources.gyp » ('j') | chrome/browser/ui/webui/settings/people_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/basic_page/basic_page.html

diff --git a/chrome/browser/resources/settings/basic_page/basic_page.html b/chrome/browser/resources/settings/basic_page/basic_page.html

index ca8e3d90e85f5978c44e099916e9fca6bcf1b510..9103cf706fa912bd6006bcc3d844096d8e96f12b 100644

--- a/chrome/browser/resources/settings/basic_page/basic_page.html

+++ b/chrome/browser/resources/settings/basic_page/basic_page.html

@@ -3,6 +3,7 @@

+<link rel="import" href="chrome://md-settings/people_page/people_page.html">

@@ -11,19 +12,16 @@

-<link rel="import" href="chrome://md-settings/signin_page/signin_page.html">

</if>

<dom-module id="settings-basic-page">

-<if expr="not chromeos">

<settings-section i18n-values="page-title:peoplePageTitle"

current-route="[[currentRoute]]" section="people">

- <settings-signin-page current-route="{{currentRoute}}">

- </settings-signin-page>

+ <settings-people-page current-route="{{currentRoute}}">

+ </settings-people-page>

</settings-section>

-</if>

<settings-section i18n-values="page-title:internetPageTitle"

current-route="[[currentRoute]]" section="internet">