win_toolchain: Add DIA SDK to extracted pieces

win_toolchain/toolchain2013.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Extracts a Windows VS2013 toolchain from various downloadable pieces."""
 
 
 import ctypes
 import optparse
@@ skipping 22 matching lines @@
   size = ctypes.windll.kernel32.GetLongPathNameW(unicode(path), buf, 260)
   if (size > 260):
     sys.exit('Long form of path longer than 260 chars: %s' % path)
   return buf.value
 
 
 def RunOrDie(command):
   subprocess.check_call(command, shell=True)
 
 
+class ScopedSubstTempDir(object):
+  """Creates a |TempDir()| and subst's a drive to the path. This is done to

[M-A Ruel, 2014/02/13 02:49:38]

Single line summary.

Description.

[scottmg, 2014/02/13 17:58:27]

Done.

+  avoid exceedingly long names in some .msi packages which fail to extract
+  because they exceed _MAX_PATH. Only the "subst" part of this is scoped, not

[M-A Ruel, 2014/02/13 02:49:38]

Oh God I Hate Windows.

[scottmg, 2014/02/13 17:58:27]

Great, isn't it! Should have been a 3 line CL... :/

+  the temp dir, which is left for use and cleanup by the caller.
+  """
+  DefineDosDevice = ctypes.windll.kernel32.DefineDosDeviceW
+  DefineDosDevice.argtypes = [ctypes.c_int, ctypes.c_wchar_p, ctypes.c_wchar_p]
+  DDD_NO_BROADCAST_SYSTEM = 0x08
+  DDD_REMOVE_DEFINITION = 0x02
+
+  def __init__(self):
+    self.real_path = TempDir()
+    self.subst_drive = None
+
+  def __enter__(self):
+    """Tries to find a subst that we can use for the temporary directory, and
+    aborts on failure."""
+    for drive in range(ord('Z'), ord('A') - 1, -1):
+      candidate = '%c:' % drive
+      if self.DefineDosDevice(
+          self.DDD_NO_BROADCAST_SYSTEM, candidate, self.real_path) != 0:
+        self.subst_drive = candidate
+        return self
+    raise RuntimeError("Unable to find a subst path")

[M-A Ruel, 2014/02/13 02:49:38]

''

[scottmg, 2014/02/13 17:58:27]

Done.

+
+  def __exit__(self, typ, value, traceback):
+    if self.subst_drive:
+      if self.DefineDosDevice(int(self.DDD_REMOVE_DEFINITION),
+                              self.subst_drive,
+                              self.real_path) == 0:
+        raise RuntimeError("Unable to remove subst")
+
+  def ShortenedPath(self):
+    return self.subst_drive + '\\'
+
+  def RealPath(self):
+    return self.real_path
+
+
 def TempDir():
   """Generates a temporary directory (for downloading or extracting to) and keep
   track of the directory that's created for cleaning up later.
   """
   temp = tempfile.mkdtemp()
   g_temp_dirs.append(temp)
   return temp
 
 
 def DeleteAllTempDirs():
@@ skipping 56 matching lines @@
   # TODO(scottmg): Do this (and exe) manually with python code.
   # Note that at the beginning of main() we set the working directory to 7z's
   # location so that 7z can find its codec dll.
   RunOrDie('7z x "%s" -y "-o%s" >nul' % (iso_path, target_path))
   return target_path
 
 
 def ExtractMsi(msi_path):
   """Uses msiexec to extract the contents of the given .msi file."""
   sys.stdout.write('Extracting %s...\n' % msi_path)
-  target_path = TempDir()
-  RunOrDie('msiexec /a "%s" /qn TARGETDIR="%s"' % (msi_path, target_path))
-  return target_path
+  with ScopedSubstTempDir() as temp_dir:
+    RunOrDie('msiexec /a "%s" /qn TARGETDIR="%s"' % (
+               msi_path, temp_dir.ShortenedPath()))
+    return temp_dir.RealPath()
 
 
 def DownloadMainIso(url):
   temp_dir = TempDir()
   target_path = os.path.join(temp_dir, os.path.basename(url))
   Download(url, target_path)
   return target_path
 
 
 def DownloadSDK8():
@@ skipping 123 matching lines @@
       (r'vc_compilerCore86\vc_compilerCore86.msi', True),
       (r'vc_compilerCore86res\vc_compilerCore86res.msi', True),
       (r'vc_compilerx64nat\vc_compilerx64nat.msi', False),
       (r'vc_compilerx64natres\vc_compilerx64natres.msi', False),
       (r'vc_compilerx64x86\vc_compilerx64x86.msi', False),
       (r'vc_compilerx64x86res\vc_compilerx64x86res.msi', False),
       (r'vc_librarycore86\vc_librarycore86.msi', True),
       (r'vc_libraryDesktop\x64\vc_LibraryDesktopX64.msi', True),
       (r'vc_libraryDesktop\x86\vc_LibraryDesktopX86.msi', True),
       (r'vc_libraryextended\vc_libraryextended.msi', False),
+      (r'professionalcore\Setup\vs_professionalcore.msi', False),
     ]
   extracted_iso = ExtractIso(image.vs_path)
   result = ExtractMsiList(os.path.join(extracted_iso, 'packages'), vs_packages)
 
   sdk_packages = [
       (r'X86 Debuggers And Tools-x86_en-us.msi', True),
       (r'X64 Debuggers And Tools-x64_en-us.msi', True),
       (r'SDK Debuggers-x86_en-us.msi', True),
       (r'Windows Software Development Kit-x86_en-us.msi', True),
       (r'Windows Software Development Kit for Metro style Apps-x86_en-us.msi',
@@ skipping 13 matching lines @@
     extracted_iso = ExtractIso(image.wdk_path)
     result.extend(ExtractMsiList(os.path.join(extracted_iso, 'WDK'),
                                  wdk_packages))
 
   return result
 
 
 def CopyToFinalLocation(extracted_dirs, target_dir):
   sys.stdout.write('Copying to final location...\n')
   mappings = {
-      'Program Files\\Microsoft Visual Studio 12.0\\': '.\\',
+      'Program Files\\Microsoft Visual Studio 12.0\\VC\\': 'VC\\',
+      'Program Files\\Microsoft Visual Studio 12.0\\DIA SDK\\': 'DIA SDK\\',
       'System64\\': 'sys64\\',
       'System\\': 'sys32\\',
       'Windows Kits\\8.0\\': 'win8sdk\\',
       'WinDDK\\7600.16385.win7_wdk.100208-1538\\': 'wdk\\',
   }
   matches = []
   for extracted_dir in extracted_dirs:
     for root, _, filenames in os.walk(extracted_dir):
       for filename in filenames:
         matches.append((extracted_dir, os.path.join(root, filename)))
@@ skipping 104 matching lines @@
     GenerateSetEnvCmd(target_dir, not options.express)
     with open(os.path.join(target_dir, '.version'), 'w') as f:
       f.write('express' if options.express else 'pro')
   finally:
     if options.clean:
       DeleteAllTempDirs()
 
 
 if __name__ == '__main__':
   sys.exit(main())