win_toolchain: Add DIA SDK to extracted pieces

win_toolchain: Add DIA SDK to extracted pieces

The goal of this change is to include the DIA SDK (and strip out
a bit extra that was unnecessary).

Unfortunately, the msi that includes the DIA SDK includes a file with an
extraordinarily long path, 241 characters long. When prepended with
"C:\Program Files (x86)\" it extracts OK, however, when we extract to
%TEMP% it's not hard for it to exceed _MAX_PATH and have the msi tool
fail. So, when extracting MSIs, also do the equivalent of
"subst X: temp_dir" and use X:\ as the path given to msiexec. (sigh)

R=maruel@chromium.org
BUG=323300
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251085

[M-A Ruel, 2014-02-13 02:49:38]

https://codereview.chromium.org/150333005/diff/130001/win_toolchain/toolchain...
File win_toolchain/toolchain2013.py (right):

https://codereview.chromium.org/150333005/diff/130001/win_toolchain/toolchain...
win_toolchain/toolchain2013.py:44: """Creates a |TempDir()| and subst's a drive
to the path. This is done to
Single line summary.

Description.

https://codereview.chromium.org/150333005/diff/130001/win_toolchain/toolchain...
win_toolchain/toolchain2013.py:46: because they exceed _MAX_PATH. Only the
"subst" part of this is scoped, not
Oh God I Hate Windows.

https://codereview.chromium.org/150333005/diff/130001/win_toolchain/toolchain...
win_toolchain/toolchain2013.py:67: raise RuntimeError("Unable to find a subst
path")
''

[scottmg, 2014-02-13 17:58:27]

https://codereview.chromium.org/150333005/diff/130001/win_toolchain/toolchain...
File win_toolchain/toolchain2013.py (right):

https://codereview.chromium.org/150333005/diff/130001/win_toolchain/toolchain...
win_toolchain/toolchain2013.py:44: """Creates a |TempDir()| and subst's a drive
to the path. This is done to
On 2014/02/13 02:49:38, M-A Ruel wrote:
> Single line summary.
> 
> Description.

Done.

https://codereview.chromium.org/150333005/diff/130001/win_toolchain/toolchain...
win_toolchain/toolchain2013.py:46: because they exceed _MAX_PATH. Only the
"subst" part of this is scoped, not
On 2014/02/13 02:49:38, M-A Ruel wrote:
> Oh God I Hate Windows.

Great, isn't it! Should have been a 3 line CL... :/

https://codereview.chromium.org/150333005/diff/130001/win_toolchain/toolchain...
win_toolchain/toolchain2013.py:67: raise RuntimeError("Unable to find a subst
path")
On 2014/02/13 02:49:38, M-A Ruel wrote:
> ''

Done.

[M-A Ruel, 2014-02-13 18:01:31]

lgtm

[scottmg, 2014-02-13 18:18:08]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-02-13 18:19:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/150333005/190001

[commit-bot: I haz the power, 2014-02-13 18:19:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 18:19:46]

Failed to apply patch for depot_tools/win_toolchain/toolchain_vs2013.hash:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file depot_tools/win_toolchain/toolchain_vs2013.hash
  Hunk #1 FAILED at 1.
  1 out of 1 hunk FAILED -- saving rejects to file
depot_tools/win_toolchain/toolchain_vs2013.hash.rej

Patch:       depot_tools/win_toolchain/toolchain_vs2013.hash
Index: win_toolchain/toolchain_vs2013.hash
diff --git depot_tools/win_toolchain/toolchain_vs2013.hash
depot_tools/win_toolchain/toolchain_vs2013.hash
index
d6b0bee36b6f9c005478b4f6f0977c130adc44f4..1cec0683b02bf961eaea35ab4799c2a4a11ad1e9
100644
--- a/depot_tools/win_toolchain/toolchain_vs2013.hash
+++ b/depot_tools/win_toolchain/toolchain_vs2013.hash
@@ -1,2 +1,2 @@
-627d3dc8e237717ceed024554fede5f41522f5e6
-1dd80dff1c6b2fc79b586c7d3df303ad68426f58
+0bbca7f56298c3075b183cd9d11b3529c88ce775
+9d48ee27f0d29e02fd89dd5d1d6208bf42fd6e16

[scottmg, 2014-02-13 18:24:58]

Committed patchset #6 manually as r251085 (presubmit successful).