Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: gpu/config/gpu_info_collector_unittest.cc

Issue 1503223005: Identify the active GPU using GL strings in multiple GPU situation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/config/gpu_info_collector.cc ('k') | gpu/config/software_rendering_list_json.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/config/gpu_info_collector_unittest.cc
diff --git a/gpu/config/gpu_info_collector_unittest.cc b/gpu/config/gpu_info_collector_unittest.cc
index 76fc31b2a6e589aa818f0d7bdea105ec5ad327fe..9f038a987ecfb383a5b1845ffae570f07ab3f818 100644
--- a/gpu/config/gpu_info_collector_unittest.cc
+++ b/gpu/config/gpu_info_collector_unittest.cc
@@ -302,5 +302,57 @@ TEST_F(CollectDriverInfoGLTest, CollectDriverInfoGL) {
}
}
+TEST(MultiGPUsTest, IdentifyActiveGPU) {
+ GPUInfo::GPUDevice nvidia_gpu;
+ nvidia_gpu.vendor_id = 0x10de;
+ nvidia_gpu.device_id = 0x0df8;
+ GPUInfo::GPUDevice intel_gpu;
+ intel_gpu.vendor_id = 0x8086;
+ intel_gpu.device_id = 0x0416;
+
+ GPUInfo gpu_info;
+ gpu_info.gpu = nvidia_gpu;
+ gpu_info.secondary_gpus.push_back(intel_gpu);
+
+ EXPECT_FALSE(gpu_info.gpu.active);
+ EXPECT_FALSE(gpu_info.secondary_gpus[0].active);
+
+ IdentifyActiveGPU(&gpu_info);
+ EXPECT_FALSE(gpu_info.gpu.active);
+ EXPECT_FALSE(gpu_info.secondary_gpus[0].active);
+
+ gpu_info.gl_vendor = "Intel Open Source Technology Center";
+ gpu_info.gl_renderer = "Mesa DRI Intel(R) Haswell Mobile";
+ IdentifyActiveGPU(&gpu_info);
+ EXPECT_FALSE(gpu_info.gpu.active);
+ EXPECT_TRUE(gpu_info.secondary_gpus[0].active);
+
+ gpu_info.gl_vendor = "NVIDIA Corporation";
+ gpu_info.gl_renderer = "Quadro 600/PCIe/SSE2";
+ IdentifyActiveGPU(&gpu_info);
+ EXPECT_TRUE(gpu_info.gpu.active);
+ EXPECT_FALSE(gpu_info.secondary_gpus[0].active);
+}
+
+TEST(MultiGPUsTest, IdentifyActiveGPUAvoidFalseMatch) {
+ // Verify that "Corporation" won't be matched with "ati".
+ GPUInfo::GPUDevice amd_gpu;
+ amd_gpu.vendor_id = 0x1002;
+ amd_gpu.device_id = 0x0df8;
+ GPUInfo::GPUDevice intel_gpu;
+ intel_gpu.vendor_id = 0x8086;
+ intel_gpu.device_id = 0x0416;
+
+ GPUInfo gpu_info;
+ gpu_info.gpu = amd_gpu;
+ gpu_info.secondary_gpus.push_back(intel_gpu);
+
+ gpu_info.gl_vendor = "Google Corporation";
+ gpu_info.gl_renderer = "Chrome GPU Team";
+ IdentifyActiveGPU(&gpu_info);
+ EXPECT_FALSE(gpu_info.gpu.active);
+ EXPECT_FALSE(gpu_info.secondary_gpus[0].active);
+}
+
} // namespace gpu
« no previous file with comments | « gpu/config/gpu_info_collector.cc ('k') | gpu/config/software_rendering_list_json.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698