Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1660)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1503213003: Make GrAtlasTextBlob non-virtual (Closed)

Created:
5 years ago by joshua.litt
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make GrAtlasTextBlob non-virtual BUG=skia: Committed: https://skia.googlesource.com/skia/+/b3adc2690aabfc539afcb06ad15ea792039b8325

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/gpu/GrAtlasTextBlob.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
Total mystery why this was virtual.
5 years ago (2015-12-07 21:04:03 UTC) #2
mtklein
lgtm
5 years ago (2015-12-07 21:14:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503213003/1
5 years ago (2015-12-07 21:14:24 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-07 21:26:34 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b3adc2690aabfc539afcb06ad15ea792039b8325

Powered by Google App Engine
This is Rietveld 408576698