Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1503213002: Add comment about lock_ in MidiManager::AccumulateMidiBytesSent (Closed)

Created:
5 years ago by Adam Goode
Modified:
5 years ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add comment about lock_ in MidiManager::AccumulateMidiBytesSent BUG=564501 Committed: https://crrev.com/5e766f50703e98ea6c25ea630993047f3deed31d Cr-Commit-Position: refs/heads/master@{#363721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M media/midi/midi_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Adam Goode
5 years ago (2015-12-07 19:59:20 UTC) #2
Takashi Toyoshima
lgtm
5 years ago (2015-12-08 02:28:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503213002/1
5 years ago (2015-12-08 02:30:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 03:46:02 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-08 03:46:43 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5e766f50703e98ea6c25ea630993047f3deed31d
Cr-Commit-Position: refs/heads/master@{#363721}

Powered by Google App Engine
This is Rietveld 408576698