Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 15032: Use appropriate version of delete in storage block... (Closed)

Created:
12 years ago by Craig Schlenter
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Use appropriate version of delete in storage block depending on how storage was allocated.

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M net/disk_cache/storage_block.h View 2 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/storage_block-inl.h View 1 2 3 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Craig Schlenter
I'm not sure who can review this but it should fix an error that valgrind ...
12 years ago (2008-12-18 05:48:07 UTC) #1
Peter Kasting
Added Ricardo to reviewers. There's a couple of things in this file that look odd ...
12 years ago (2008-12-18 06:17:03 UTC) #2
Craig Schlenter
Thanks for the review Peter. I have added a function now to do the deleting ...
12 years ago (2008-12-18 06:53:58 UTC) #3
Peter Kasting
LGTM http://codereview.chromium.org/15032/diff/5/6 File net/disk_cache/storage_block-inl.h (right): http://codereview.chromium.org/15032/diff/5/6#newcode122 Line 122: if (own_data_) { Nit: I'd use an ...
12 years ago (2008-12-18 07:13:23 UTC) #4
rvargas (doing something else)
http://codereview.chromium.org/15032/diff/5/6 File net/disk_cache/storage_block-inl.h (right): http://codereview.chromium.org/15032/diff/5/6#newcode126 Line 126: delete[] data_; This is not correct. Although it ...
12 years ago (2008-12-18 18:53:17 UTC) #5
Craig Schlenter
Thanks!! I should have searched issue tracker first and brushed up on my placement new ...
12 years ago (2008-12-19 05:12:18 UTC) #6
Craig Schlenter
Uploaded a fresh patch that calls the destructor and then does a delete[] with cast. ...
12 years ago (2008-12-19 07:17:00 UTC) #7
rvargas (doing something else)
12 years ago (2008-12-19 20:50:18 UTC) #8
LGTM

On 2008/12/19 07:17:00, Craig Schlenter wrote:
> Uploaded a fresh patch that calls the destructor and then does a delete[] with
> cast. I'll add a comment in issue 5041 too pointing to here.

Powered by Google App Engine
This is Rietveld 408576698