Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1503173003: Remove SK_IGNORE_GL_TEXTURE_TARGET from skia_for_chromium_defines.gypi (Closed)

Created:
5 years ago by bsalomon
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SK_IGNORE_GL_TEXTURE_TARGET from skia_for_chromium_defines.gypi This has been added to Chrome's SkUserConfig.h Committed: https://skia.googlesource.com/skia/+/987deab2b522ab7c3f402698bb9cfcc0dc4b162f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M gyp/skia_for_chromium_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
bsalomon
5 years ago (2015-12-07 21:33:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503173003/1
5 years ago (2015-12-07 21:33:25 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years ago (2015-12-07 21:33:25 UTC) #5
robertphillips1
lgtm
5 years ago (2015-12-07 22:04:12 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-07 22:05:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/987deab2b522ab7c3f402698bb9cfcc0dc4b162f

Powered by Google App Engine
This is Rietveld 408576698