content/renderer/media/webrtc_audio_capturer.cc - Issue 15031003: Fixed the crash when the WebRtcAudioCapturer::|buffer_| is NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_capturer.cc

Issue 15031003: Fixed the crash when the WebRtcAudioCapturer::|buffer_| is NULL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/webrtc_audio_capturer.cc

diff --git a/content/renderer/media/webrtc_audio_capturer.cc b/content/renderer/media/webrtc_audio_capturer.cc

index 92951e25ea9b7a75aa6bb8030194ae080afb0e4d..920f0f0d4db12abf51e20e856b64134f7b016b2f 100644

--- a/content/renderer/media/webrtc_audio_capturer.cc

+++ b/content/renderer/media/webrtc_audio_capturer.cc

@@ -379,7 +379,7 @@ void WebRtcAudioCapturer::OnCaptureError() {

media::AudioParameters WebRtcAudioCapturer::audio_parameters() const {

base::AutoLock auto_lock(lock_);

- return buffer_->params();

+ return buffer_.get() ? buffer_->params() : media::AudioParameters();

henrika (OOO until Aug 14) 2013/05/07 09:13:27 Add comment about why this can happen and what the

no longer working on chromium 2013/05/07 09:21:48 Done.

}

} // namespace content