Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15031003: Fixed the crash when the WebRtcAudioCapturer::|buffer_| is NULL (Closed)

Created:
7 years, 7 months ago by no longer working on chromium
Modified:
7 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fixed the crash when the WebRtcAudioCapturer::|buffer_| is NULL, this can happen when the capturer is not correctly initialized. BUG=238388 TEST=http://simpl.info/webaudio R=henrika@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198717

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed Henrik's comments #

Patch Set 3 : fixed the bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M content/renderer/media/webrtc_audio_capturer.cc View 1 2 2 chunks +12 lines, -1 line 0 comments Download
M content/renderer/media/webrtc_local_audio_track.cc View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
no longer working on chromium
Henrik, could you please review this CL?
7 years, 7 months ago (2013-05-07 08:32:04 UTC) #1
no longer working on chromium
7 years, 7 months ago (2013-05-07 09:10:00 UTC) #2
henrika (OOO until Aug 14)
LGTM w/ nits. https://codereview.chromium.org/15031003/diff/1/content/renderer/media/webrtc_audio_capturer.cc File content/renderer/media/webrtc_audio_capturer.cc (right): https://codereview.chromium.org/15031003/diff/1/content/renderer/media/webrtc_audio_capturer.cc#newcode382 content/renderer/media/webrtc_audio_capturer.cc:382: return buffer_.get() ? buffer_->params() : media::AudioParameters(); ...
7 years, 7 months ago (2013-05-07 09:13:27 UTC) #3
no longer working on chromium
https://codereview.chromium.org/15031003/diff/1/content/renderer/media/webrtc_audio_capturer.cc File content/renderer/media/webrtc_audio_capturer.cc (right): https://codereview.chromium.org/15031003/diff/1/content/renderer/media/webrtc_audio_capturer.cc#newcode382 content/renderer/media/webrtc_audio_capturer.cc:382: return buffer_.get() ? buffer_->params() : media::AudioParameters(); On 2013/05/07 09:13:27, ...
7 years, 7 months ago (2013-05-07 09:21:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/15031003/14001
7 years, 7 months ago (2013-05-07 09:22:04 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=126036
7 years, 7 months ago (2013-05-07 10:42:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/15031003/28001
7 years, 7 months ago (2013-05-07 11:11:56 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=124862
7 years, 7 months ago (2013-05-07 11:34:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/15031003/28001
7 years, 7 months ago (2013-05-07 14:08:22 UTC) #9
no longer working on chromium
7 years, 7 months ago (2013-05-07 14:09:52 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 manually as r198717 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698