Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1503063002: Handle const loop variable. (Closed)

Created:
5 years ago by Johnni Winther
Modified:
5 years ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -22 lines) Patch
M pkg/compiler/lib/src/diagnostics/messages.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 1 2 chunks +17 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/variables.dart View 1 chunk +8 lines, -3 lines 0 comments Download
A + tests/language/const_for_in_variable_test.dart View 1 chunk +7 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
5 years ago (2015-12-07 14:26:52 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1503063002/diff/1/pkg/compiler/lib/src/parser/parser.dart File pkg/compiler/lib/src/parser/parser.dart (right): https://codereview.chromium.org/1503063002/diff/1/pkg/compiler/lib/src/parser/parser.dart#newcode666 pkg/compiler/lib/src/parser/parser.dart:666: String value1, String value2, String value3) { Indentation. ...
5 years ago (2015-12-08 09:23:30 UTC) #3
Johnni Winther
https://codereview.chromium.org/1503063002/diff/1/pkg/compiler/lib/src/parser/parser.dart File pkg/compiler/lib/src/parser/parser.dart (right): https://codereview.chromium.org/1503063002/diff/1/pkg/compiler/lib/src/parser/parser.dart#newcode666 pkg/compiler/lib/src/parser/parser.dart:666: String value1, String value2, String value3) { On 2015/12/08 ...
5 years ago (2015-12-08 10:07:17 UTC) #4
Johnni Winther
5 years ago (2015-12-08 10:30:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
73d269ad1f448cdc792646ed8df7b4c4c6cad0fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698