Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1503053002: MIPS: [turbofan] Make Int32Div and Uint32Div safe. (Closed)

Created:
5 years ago by dusan.milosavljevic
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Make Int32Div and Uint32Div safe. TEST= BUG= Committed: https://crrev.com/d7aa94b90b350839321561af38fea6c239aaf50e Cr-Commit-Position: refs/heads/master@{#32685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -7 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 5 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
dusan.milosavljevic
PTAL. Paul, please check behaviour on boards with emulated FPU in kernel. The DIV, and ...
5 years ago (2015-12-07 14:21:53 UTC) #2
paul.l...
Tests passed on hw with/without FPU. LGTM.
5 years ago (2015-12-08 04:46:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503053002/1
5 years ago (2015-12-08 12:29:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11145)
5 years ago (2015-12-08 12:59:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503053002/1
5 years ago (2015-12-08 14:20:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/11765)
5 years ago (2015-12-08 15:13:10 UTC) #11
Jakob Kummerow
On 2015/12/08 15:13:10, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-12-08 15:16:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503053002/1
5 years ago (2015-12-08 21:50:30 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 22:45:37 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-08 22:46:49 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7aa94b90b350839321561af38fea6c239aaf50e
Cr-Commit-Position: refs/heads/master@{#32685}

Powered by Google App Engine
This is Rietveld 408576698