Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1503003002: Paginated containers are opaque to enclosing fragmentation contexts. (Closed)

Created:
5 years ago by mstensho (USE GERRIT)
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Paginated containers are opaque to enclosing fragmentation contexts. Only multicol containers may be fragmented by enclosing fragmentation contexts. Unlike multicol containers, containers with overflow:paged-x or paged-y cannot create additional fragmentainer groups for each outer column that it lives in. Added a basic test for multicol inside paged overflow, since it was missing, just to make sure that this CL doesn't break anything. BUG=479074 R=leviw@chromium.org Committed: https://crrev.com/3dedc30668096630df47544271d0e488463ad7ec Cr-Commit-Position: refs/heads/master@{#364036}

Patch Set 1 #

Patch Set 2 : rebase master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -8 lines) Patch
A + third_party/WebKit/LayoutTests/fast/multicol/paged-in-multicol-crash.html View 1 chunk +4 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/multicol/paged-in-multicol-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/pagination/multicol.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/pagination/multicol-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ColumnBalancer.cpp View 1 2 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
leviw_travelin_and_unemployed
lgtm
5 years ago (2015-12-09 01:03:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503003002/1
5 years ago (2015-12-09 01:35:16 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/155112) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years ago (2015-12-09 01:51:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503003002/20001
5 years ago (2015-12-09 09:03:26 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-09 10:36:32 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-09 10:38:14 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3dedc30668096630df47544271d0e488463ad7ec
Cr-Commit-Position: refs/heads/master@{#364036}

Powered by Google App Engine
This is Rietveld 408576698