Use a sysroot for Chrome Linux official builds. (try 2)

Use a sysroot for Chrome Linux official builds. (try 2)

BUG=224487
R=mmoss@google.com

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198856

[Lei Zhang, 2013-05-07 06:54:36]

I guess the last try was good for seeing what issues existed on the waterfall.
This next iteration adds a wrapper script, and has the lsb_release check to
prevent using the sysroot on Lucid 'official' builders.

[mmoss, 2013-05-07 15:00:01]

lgtm with optional nit

[mmoss, 2013-05-07 15:00:10]

https://codereview.chromium.org/15030002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/15030002/diff/1/build/common.gypi#newcode177
build/common.gypi:177: # official Ubuntu Lucid builder are gone.
I don't feel strongly about this either way, but would it be easier/cleaner to
put this check in the sysroot script? This seems like a lot of cruft to add here
(temporarily) when it could be just a couple lines added to that script.

[Lei Zhang, 2013-05-07 21:37:48]

https://codereview.chromium.org/15030002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/15030002/diff/1/build/common.gypi#newcode177
build/common.gypi:177: # official Ubuntu Lucid builder are gone.
On 2013/05/07 15:00:10, mmoss wrote:
> I don't feel strongly about this either way, but would it be easier/cleaner to
> put this check in the sysroot script? This seems like a lot of cruft to add
here
> (temporarily) when it could be just a couple lines added to that script.

Well, the part in the .gypi file here controls whether we set the sysroot gyp
variable or not. This is independent of whether or not we install a sysroot.

It doesn't make sense to set the sysroot variable and not have the sysroot
directory. That'll just cause the build to fail.

[Lei Zhang, 2013-05-08 07:20:10]

Committed patchset #1 manually as r198856 (presubmit successful).