Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1502983002: [proxies] Make Object.{isFrozen,isSealed} behave correctly for proxies. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Make Object.{isFrozen,isSealed} behave correctly for proxies. R=rossberg BUG= Committed: https://crrev.com/ef1ac7290163362aca3f599e975d82b2f6c9d29e Cr-Commit-Position: refs/heads/master@{#32660}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -35 lines) Patch
M src/js/v8natives.js View 1 1 chunk +8 lines, -35 lines 0 comments Download
M src/objects.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +32 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 chunks +22 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/proxies-integrity.js View 1 1 chunk +118 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
neis
5 years ago (2015-12-07 10:40:37 UTC) #1
rossberg
lgtm https://codereview.chromium.org/1502983002/diff/1/test/mjsunit/harmony/proxies-integrity.js File test/mjsunit/harmony/proxies-integrity.js (right): https://codereview.chromium.org/1502983002/diff/1/test/mjsunit/harmony/proxies-integrity.js#newcode102 test/mjsunit/harmony/proxies-integrity.js:102: target.wurst = 42; I highly prefer kaese. https://codereview.chromium.org/1502983002/diff/1/test/mjsunit/harmony/proxies-integrity.js#newcode115 ...
5 years ago (2015-12-07 14:00:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502983002/20001
5 years ago (2015-12-07 15:14:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-07 15:35:55 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-07 15:36:18 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ef1ac7290163362aca3f599e975d82b2f6c9d29e
Cr-Commit-Position: refs/heads/master@{#32660}

Powered by Google App Engine
This is Rietveld 408576698