Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1502963002: [ic] Change CompareIC to handle JSReceiver instead of JSObject. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Change CompareIC to handle JSReceiver instead of JSObject. There's no reason to limit the CompareIC to (known) JSObject instances, as all JSReceivers behave the same wrt. abstract and strict equality. So remove this historical limitation and track JSReceivers instead. R=yangguo@chromium.org Committed: https://crrev.com/0ed0878041574382b75d4d549f3ff73afcc72efb Cr-Commit-Position: refs/heads/master@{#32642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -78 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M src/code-stubs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ic/ic-state.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ic/ic-state.cc View 6 chunks +19 lines, -19 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
5 years ago (2015-12-07 06:41:41 UTC) #1
Yang
On 2015/12/07 06:41:41, Benedikt Meurer wrote: lgtm.
5 years ago (2015-12-07 07:22:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502963002/1
5 years ago (2015-12-07 07:23:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 07:25:07 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-07 07:25:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ed0878041574382b75d4d549f3ff73afcc72efb
Cr-Commit-Position: refs/heads/master@{#32642}

Powered by Google App Engine
This is Rietveld 408576698