Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 15029010: Remove CTEC.MIXIN_OF_NON_MIXIN and MIXIN_WITH_NON_CLASS_SUPERCLASS. (Closed)

Created:
7 years, 7 months ago by scheglov
Modified:
7 years, 7 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Remove CTEC.MIXIN_OF_NON_MIXIN and MIXIN_WITH_NON_CLASS_SUPERCLASS. I believe these codes are covered by the more specific MIXIN_REFERENCES_SUPER, MIXIN_DECLARES_CONSTRUCTOR and MIXIN_INHERITS_FROM_NOT_OBJECT. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22626

Patch Set 1 #

Patch Set 2 : Report MIXIN_WITH_NON_CLASS_SUPERCLASS #

Messages

Total messages: 6 (0 generated)
scheglov
7 years, 7 months ago (2013-05-10 22:07:14 UTC) #1
Brian Wilkerson
I agree that MIXIN_OF_NON_MIXIN appears to be covered by the more specific errors you mentioned, ...
7 years, 7 months ago (2013-05-10 22:15:54 UTC) #2
scheglov
On 2013/05/10 22:15:54, Brian Wilkerson wrote: > I agree that MIXIN_OF_NON_MIXIN appears to be covered ...
7 years, 7 months ago (2013-05-11 03:11:02 UTC) #3
scheglov
PTAL
7 years, 7 months ago (2013-05-11 05:33:50 UTC) #4
Brian Wilkerson
LGTM
7 years, 7 months ago (2013-05-13 13:37:59 UTC) #5
scheglov
7 years, 7 months ago (2013-05-13 15:18:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r22626 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698