Issue 15029008: Fix memory leak in filter tool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15029008: Fix memory leak in filter tool (Closed)

Created:
7 years, 7 months ago by robertphillips

Modified:
7 years, 7 months ago

Reviewers:
jvanverth1, bungeman-skia

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 3

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	tools/filtermain.cpp	View		2 chunks	+7 lines, -3 lines	3 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jvanverth1

Trying it out on the big list, I'll let you know how it goes. Until ...

7 years, 7 months ago (2013-05-10 14:34:46 UTC) #2

robertphillips

https://codereview.chromium.org/15029008/diff/1/tools/filtermain.cpp File tools/filtermain.cpp (right): https://codereview.chromium.org/15029008/diff/1/tools/filtermain.cpp#newcode721 tools/filtermain.cpp:721: Yep - when enabled it prints out leak info

7 years, 7 months ago (2013-05-10 14:36:18 UTC) #3

bungeman-skia

7 years, 7 months ago (2013-05-10 17:30:36 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/15029008/diff/1/tools/filtermain.cpp
File tools/filtermain.cpp (right):

https://codereview.chromium.org/15029008/diff/1/tools/filtermain.cpp#newcode629
tools/filtermain.cpp:629: SkAutoTDelete<SkPicture> inPicture;
SkPicture is SkRefCnt, it seems odd to SkAutoTDelete it. Did you mean
SkAutoTUnref? SkAutoTDelete kida-sorta works here since you're the one creating
the picture, but that's somewhat magic knowledge.

Expand Messages | Collapse Messages

Issue 15029008: Fix memory leak in filter tool (Closed)

Description

Patch Set 1 #

Messages