CrOS Files.app: fix the redraw logic on resize.

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * This variable is checked in SelectFileDialogExtensionBrowserTest.
  * @type {number}
  */
@@ skipping 918 matching lines @@
     this.updateWindowState_();
 
     // Populate the static localized strings.
     i18nTemplate.process(this.document_, loadTimeData);
 
     // Initialize the new header and arrange the file list.
     if (util.platform.newUI()) {
       this.dialogDom_.querySelector('#app-name').innerText =
           chrome.runtime.getManifest().name;
       this.table_.normalizeColumns();
+      this.table_.redraw();
     }
   };
 
   /**
    * @private
    */
   FileManager.prototype.onBreadcrumbClick_ = function(event) {
     this.directoryModel_.changeDirectory(event.path);
   };
 
@@ skipping 454 matching lines @@
   FileManager.prototype.onResize_ = function() {
     if (this.listType_ == FileManager.ListType.THUMBNAIL) {
       var g = this.grid_;
       g.startBatchUpdates();
       setTimeout(function() {
         g.columns = 0;
         g.redraw();
         g.endBatchUpdates();
       }, 0);
     } else {
+      if (util.platform.newUI()) {
+        if (this.table_.clientWidth > 0)

[mtomasz, 2013/05/07 08:37:53]

Do we need this? What's the purpose of it? If the list is hidden then it is
empty, then normalizing doesn't cost anything.

[mtomasz, 2013/05/07 08:44:58]

OK, now I see. My repro steps for this are:
1. Open Files.app.
2. Open a picture.
3. Resize.
4. Close the gallery.

Result: empty.
Expected: not empty.

This still happens with this patch. It may be a race with closeFilePopup_'s
setTimeout(this.onResize_.bind(this), 0), I am not sure.

[mtomasz, 2013/05/07 09:15:34]

This check for clientWidth > 0 seem to me unnecessary.

[yoshiki, 2013/05/07 09:51:04]

We need this check. When this.table_.clientWidth=0, in
FileTableColumnModel.normalizeWidth(), the 'factor' variable is set to negative
value (l.49) and all the column widthes are set to negative value at (l.54).

+          this.table_.normalizeColumns();
+      }
       this.table_.redraw();
-      if (util.platform.newUI())
-        this.table_.normalizeColumns();
     }
 
     if (!util.platform.newUI())
       this.breadcrumbs_.truncate();
 
     this.searchBreadcrumbs_.truncate();
 
     this.updateWindowState_();
   };
 
@@ skipping 2211 matching lines @@
    * Set the flag expressing whether the ctrl key is pressed or not.
    * @param {boolean} flag New value of the flag
    * @private
    */
   FileManager.prototype.setCtrlKeyPressed_ = function(flag) {
     this.ctrlKeyPressed_ = flag;
     this.document_.querySelector('#drive-clear-local-cache').canExecuteChange();
     this.document_.querySelector('#drive-reload').canExecuteChange();
   };
 })();