Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15028002: Delete test_shell. (Closed)

Created:
7 years, 7 months ago by darin (slow to review)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, vsevik, rpetterson, rouslan+spellwatch_chromium.org, sail+watch_chromium.org, yurys, darin-cc_chromium.org, dcheng, groby+spellwatch_chromium.org, pfeldman
Visibility:
Public.

Description

Patch Set 1 : Remove all.gyp references to test_shell. #

Patch Set 2 : Fix windows build. #

Patch Set 3 : Add dummy test_shell build target. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14113 lines) Patch
M build/all.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
D webkit/tools/test_shell/accessibility_ui_element.h View 1 chunk +0 lines, -184 lines 0 comments Download
D webkit/tools/test_shell/accessibility_ui_element.cc View 1 chunk +0 lines, -633 lines 0 comments Download
D webkit/tools/test_shell/drop_delegate.h View 1 chunk +0 lines, -40 lines 0 comments Download
D webkit/tools/test_shell/drop_delegate.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D webkit/tools/test_shell/mac/English.lproj/InfoPlist.strings View 1 chunk +0 lines, -3 lines 0 comments Download
D webkit/tools/test_shell/mac/English.lproj/MainMenu.xib View 1 chunk +0 lines, -2072 lines 0 comments Download
D webkit/tools/test_shell/mac/Info.plist View 1 chunk +0 lines, -28 lines 0 comments Download
D webkit/tools/test_shell/mac/TestShell_Prefix.pch View 1 chunk +0 lines, -7 lines 0 comments Download
D webkit/tools/test_shell/mac/test_shell.icns View 0 chunks +-1 lines, --1 lines 0 comments Download
D webkit/tools/test_shell/mac/test_shell_webview.h View 1 chunk +0 lines, -45 lines 0 comments Download
D webkit/tools/test_shell/mac/test_shell_webview.mm View 1 chunk +0 lines, -211 lines 0 comments Download
D webkit/tools/test_shell/mock_spellcheck.h View 1 chunk +0 lines, -57 lines 0 comments Download
D webkit/tools/test_shell/mock_spellcheck.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D webkit/tools/test_shell/notification_presenter.h View 1 chunk +0 lines, -43 lines 0 comments Download
D webkit/tools/test_shell/notification_presenter.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D webkit/tools/test_shell/resource.h View 1 chunk +0 lines, -46 lines 0 comments Download
D webkit/tools/test_shell/resources/small.ico View Binary file 0 comments Download
D webkit/tools/test_shell/resources/test_shell.ico View Binary file 0 comments Download
D webkit/tools/test_shell/resources/test_shell.rc View 1 chunk +0 lines, -140 lines 0 comments Download
D webkit/tools/test_shell/test_navigation_controller.h View 1 chunk +0 lines, -184 lines 0 comments Download
D webkit/tools/test_shell/test_navigation_controller.cc View 1 chunk +0 lines, -230 lines 0 comments Download
D webkit/tools/test_shell/test_shell.h View 1 chunk +0 lines, -350 lines 0 comments Download
D webkit/tools/test_shell/test_shell.cc View 1 chunk +0 lines, -615 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 2 3 chunks +5 lines, -340 lines 1 comment Download
D webkit/tools/test_shell/test_shell_devtools_agent.h View 1 chunk +0 lines, -61 lines 0 comments Download
D webkit/tools/test_shell/test_shell_devtools_agent.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D webkit/tools/test_shell/test_shell_devtools_callargs.h View 1 chunk +0 lines, -28 lines 0 comments Download
D webkit/tools/test_shell/test_shell_devtools_callargs.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D webkit/tools/test_shell/test_shell_devtools_client.h View 1 chunk +0 lines, -51 lines 0 comments Download
D webkit/tools/test_shell/test_shell_devtools_client.cc View 1 chunk +0 lines, -84 lines 0 comments Download
A webkit/tools/test_shell/test_shell_dummy.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
D webkit/tools/test_shell/test_shell_gtk.cc View 1 chunk +0 lines, -549 lines 0 comments Download
D webkit/tools/test_shell/test_shell_mac.mm View 1 chunk +0 lines, -592 lines 0 comments Download
D webkit/tools/test_shell/test_shell_main.cc View 1 chunk +0 lines, -270 lines 0 comments Download
D webkit/tools/test_shell/test_shell_platform_delegate.h View 1 chunk +0 lines, -54 lines 0 comments Download
D webkit/tools/test_shell/test_shell_platform_delegate_gtk.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D webkit/tools/test_shell/test_shell_platform_delegate_mac.mm View 1 chunk +0 lines, -203 lines 0 comments Download
D webkit/tools/test_shell/test_shell_platform_delegate_win.cc View 1 chunk +0 lines, -155 lines 0 comments Download
D webkit/tools/test_shell/test_shell_resources.grd View 1 chunk +0 lines, -16 lines 0 comments Download
D webkit/tools/test_shell/test_shell_switches.h View 1 chunk +0 lines, -34 lines 0 comments Download
D webkit/tools/test_shell/test_shell_switches.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D webkit/tools/test_shell/test_shell_test.h View 1 chunk +0 lines, -39 lines 0 comments Download
D webkit/tools/test_shell/test_shell_test.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D webkit/tools/test_shell/test_shell_webkit_init.h View 1 chunk +0 lines, -123 lines 0 comments Download
D webkit/tools/test_shell/test_shell_webkit_init.cc View 1 chunk +0 lines, -292 lines 0 comments Download
D webkit/tools/test_shell/test_shell_webthemecontrol.h View 1 chunk +0 lines, -178 lines 0 comments Download
D webkit/tools/test_shell/test_shell_webthemecontrol.cc View 1 chunk +0 lines, -438 lines 0 comments Download
D webkit/tools/test_shell/test_shell_webthemeengine.h View 1 chunk +0 lines, -69 lines 0 comments Download
D webkit/tools/test_shell/test_shell_webthemeengine.cc View 1 chunk +0 lines, -576 lines 0 comments Download
D webkit/tools/test_shell/test_shell_win.cc View 1 chunk +0 lines, -676 lines 0 comments Download
D webkit/tools/test_shell/test_shell_x11.h View 1 chunk +0 lines, -22 lines 0 comments Download
D webkit/tools/test_shell/test_shell_x11.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D webkit/tools/test_shell/test_webview_delegate.h View 1 chunk +0 lines, -430 lines 0 comments Download
D webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +0 lines, -989 lines 0 comments Download
D webkit/tools/test_shell/test_webview_delegate_gtk.cc View 1 chunk +0 lines, -265 lines 0 comments Download
D webkit/tools/test_shell/test_webview_delegate_mac.mm View 1 chunk +0 lines, -284 lines 0 comments Download
D webkit/tools/test_shell/test_webview_delegate_win.cc View 1 chunk +0 lines, -207 lines 0 comments Download
D webkit/tools/test_shell/webview_host.h View 1 chunk +0 lines, -65 lines 0 comments Download
D webkit/tools/test_shell/webview_host_gtk.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D webkit/tools/test_shell/webview_host_mac.mm View 1 chunk +0 lines, -63 lines 0 comments Download
D webkit/tools/test_shell/webview_host_win.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D webkit/tools/test_shell/webwidget_host.h View 1 chunk +0 lines, -159 lines 0 comments Download
D webkit/tools/test_shell/webwidget_host.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D webkit/tools/test_shell/webwidget_host_gtk.cc View 1 chunk +0 lines, -436 lines 0 comments Download
D webkit/tools/test_shell/webwidget_host_mac.mm View 1 chunk +0 lines, -286 lines 0 comments Download
D webkit/tools/test_shell/webwidget_host_win.cc View 1 chunk +0 lines, -381 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
darin (slow to review)
7 years, 7 months ago (2013-05-07 14:11:40 UTC) #1
jochen (gone - plz use gerrit)
lgtm in trunk/tools/build/** test_shell is still referenced a lot. I guess you'll need to clean ...
7 years, 7 months ago (2013-05-07 14:18:37 UTC) #2
Avi (use Gerrit)
Farewell, test_shell.
7 years, 7 months ago (2013-05-07 14:23:00 UTC) #3
darin (slow to review)
OK, I confirmed that the Linux and Mac buildbots command the slave to build test_shell. ...
7 years, 7 months ago (2013-05-08 05:33:00 UTC) #4
jochen (gone - plz use gerrit)
https://codereview.chromium.org/15028002/diff/19001/webkit/tools/test_shell/test_shell.gypi File webkit/tools/test_shell/test_shell.gypi (right): https://codereview.chromium.org/15028002/diff/19001/webkit/tools/test_shell/test_shell.gypi#newcode36 webkit/tools/test_shell/test_shell.gypi:36: 'type': 'static_library', does 'type': 'none' and no sources not ...
7 years, 7 months ago (2013-05-08 06:40:52 UTC) #5
jochen (gone - plz use gerrit)
lgtm
7 years, 7 months ago (2013-05-08 06:50:49 UTC) #6
darin (slow to review)
On 2013/05/08 06:40:52, jochen wrote: > https://codereview.chromium.org/15028002/diff/19001/webkit/tools/test_shell/test_shell.gypi > File webkit/tools/test_shell/test_shell.gypi (right): > > https://codereview.chromium.org/15028002/diff/19001/webkit/tools/test_shell/test_shell.gypi#newcode36 > ...
7 years, 7 months ago (2013-05-08 06:52:07 UTC) #7
darin (slow to review)
7 years, 7 months ago (2013-05-08 17:54:16 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 manually as r198933 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698