Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 15027014: Fix oversight in side effects computation and closure calls. (Closed)

Created:
7 years, 7 months ago by ngeoffray
Modified:
7 years, 7 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix oversight in side effects computation and closure calls. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=22614

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -12 lines) Patch
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 1 6 chunks +17 lines, -12 lines 0 comments Download
A tests/language/closure_side_effect_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 7 months ago (2013-05-08 15:53:36 UTC) #1
kasperl
LGTM.
7 years, 7 months ago (2013-05-08 17:21:47 UTC) #2
ngeoffray
7 years, 7 months ago (2013-05-13 10:28:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22614 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698