Issue 15027013: Remove third-party cityhash, unused since r8992

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15027013: Remove third-party cityhash, unused since r8992 (Closed)

Created:
7 years, 7 months ago by epoger

Modified:
7 years, 7 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com, borenet

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove third-party cityhash, unused since r8992 R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=9059

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -215 lines)			Patch
M	DEPS	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	bench/ChecksumBench.cpp	View	5 chunks	+1 line, -22 lines	0 comments	Download
M	gm/gm_expectations.cpp	View	1 chunk	+0 lines, -8 lines	0 comments	Download
D	gyp/cityhash.gyp	View	1 chunk	+0 lines, -33 lines	0 comments	Download
M	gyp/utils.gyp	View	3 chunks	+0 lines, -14 lines	0 comments	Download
M	src/utils/SkBitmapHasher.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/utils/SkBitmapHasher.cpp	View	3 chunks	+0 lines, -18 lines	0 comments	Download
D	src/utils/SkCityHash.h	View	1 chunk	+0 lines, -47 lines	0 comments	Download
D	src/utils/SkCityHash.cpp	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	src/utils/cityhash/README	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	src/utils/cityhash/config.h	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	tests/ChecksumTest.cpp	View	4 chunks	+1 line, -28 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

epoger

"make most" works for me, out to the CQ trybots to make sure. Ready for ...

7 years, 7 months ago (2013-05-08 14:40:16 UTC) #1

epoger

https://codereview.chromium.org/15027013/diff/1/DEPS File DEPS (left): https://codereview.chromium.org/15027013/diff/1/DEPS#oldcode12 DEPS:12: "third_party/externals/cityhash" : "http://cityhash.googlecode.com/svn/trunk@11", P.S. I also removed it from ...

7 years, 7 months ago (2013-05-08 14:41:25 UTC) #2

epoger

7 years, 7 months ago (2013-05-08 14:49:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r9059 (presubmit successful).

Expand Messages | Collapse Messages