Source/core/dom/NodeRenderingContext.h - Issue 15027005: [CSS Regions] Elements in a region should be assignable to a named flow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/NodeRenderingContext.h

Issue 15027005: [CSS Regions] Elements in a region should be assignable to a named flow (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Integrates all feedback. One of the tests causes an ASSERT in ContentShell because of Region Ranges. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/regions/universal-selector-children-to-the-same-region.html ('K') | « LayoutTests/fast/regions/universal-selector-children-to-the-same-region-expected.txt ('k') | Source/core/dom/NodeRenderingContext.cpp » ('j') | Source/core/dom/NodeRenderingContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/NodeRenderingContext.h

diff --git a/Source/core/dom/NodeRenderingContext.h b/Source/core/dom/NodeRenderingContext.h

index c0e0c9d012a4dfb2d31632d15d8efa6489d316f7..71a78fc281a944fda9027e830f46391a46459896 100644

--- a/Source/core/dom/NodeRenderingContext.h

+++ b/Source/core/dom/NodeRenderingContext.h

@@ -68,14 +68,16 @@ public:

private:

bool shouldCreateRenderer() const;

+ bool shouldMoveToFlowThread() const;

+ void moveToFlowThread();

void moveToFlowThreadIfNeeded();

+ PassRefPtr<RenderStyle> getStyleForRenderer() const;

esprehn 2013/06/17 21:41:02 styleForRenderer(). Methods shouldn't be prefixed

Node* m_node;

ContainerNode* m_renderingParent;

NodeRenderingTraversal::ParentDetails m_parentDetails;

- RefPtr<RenderStyle> m_style;

+ mutable RefPtr<RenderStyle> m_style; // Cache of node's styleForRenderer.

RenderNamedFlowThread* m_parentFlowRenderer;

- AtomicString m_flowThread;

};

inline Node* NodeRenderingContext::node() const