bluetooth: Implement allowed devices map

content/browser/bluetooth/bluetooth_allowed_devices_map_unittest.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/bluetooth/bluetooth_allowed_devices_map.h"
+
+#include "base/strings/string_util.h"
+#include "content/common/bluetooth/bluetooth_scan_filter.h"
+#include "device/bluetooth/bluetooth_uuid.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace content {
+namespace {
+const std::string& test_origin1 = "test_origin1";
+const std::string& test_origin2 = "test_origin2";
+
+const std::string& device_address1 = "00:00:00";
+const std::string& device_address2 = "11:11:11";
+
+const std::vector<content::BluetoothScanFilter> filters =
+    std::vector<BluetoothScanFilter>();
+const std::vector<device::BluetoothUUID> optional_services =
+    std::vector<device::BluetoothUUID>();
+}  // namespace
+
+class BluetoothAllowedDevicesMapTest : public testing::Test {};
+
+TEST_F(BluetoothAllowedDevicesMapTest, AddDeviceToMap) {
+  BluetoothAllowedDevicesMap allowed_devices_map;
+
+  const std::string& device_id = allowed_devices_map.AddDevice(
+      test_origin1, device_address1, filters, optional_services);
+
+  // Test that we can retrieve the device address/id.
+  EXPECT_EQ(device_id,
+            allowed_devices_map.GetDeviceId(test_origin1, device_address1));
+  EXPECT_EQ(device_address1,
+            allowed_devices_map.GetDeviceAddress(test_origin1, device_id));
+}
+
+TEST_F(BluetoothAllowedDevicesMapTest, AddDeviceToMapTwice) {
+  BluetoothAllowedDevicesMap allowed_devices_map;
+  const std::string& device_id1 = allowed_devices_map.AddDevice(
+      test_origin1, device_address1, filters, optional_services);
+  const std::string& device_id2 = allowed_devices_map.AddDevice(
+      test_origin1, device_address1, filters, optional_services);
+
+  EXPECT_EQ(device_id1, device_id2);
+
+  // Test that we can retrieve the device address/id.
+  EXPECT_EQ(device_id1,
+            allowed_devices_map.GetDeviceId(test_origin1, device_address1));
+  EXPECT_EQ(device_address1,
+            allowed_devices_map.GetDeviceAddress(test_origin1, device_id1));
+}
+
+TEST_F(BluetoothAllowedDevicesMapTest, AddTwoDevicesToMap) {
+  BluetoothAllowedDevicesMap allowed_devices_map;
+  const std::string& device_id1 = allowed_devices_map.AddDevice(
+      test_origin1, device_address1, filters, optional_services);
+  const std::string& device_id2 = allowed_devices_map.AddDevice(
+      test_origin2, device_address2, filters, optional_services);

[Jeffrey Yasskin, 2016/01/13 02:31:36]

Add a test with s/device_address2/device_address1/, I think. I want to check
that the second origin gets a different ID from the first.

I think the test you have is primarily useful for the
allowed_devices_map.GetDeviceAddress(test_origin1, device_id2)) == "" case; you
can probably remove the check that retrieving the device address/id works, since
it's tested in AddDeviceToMap.

[ortuno, 2016/01/13 21:34:31]

Done.
hrmm I kept the check for retrieving with address/id. I'm scared of replacing a
previous device and not noticing or putting the new device in the wrong origin.
Also added a test for when adding two devices from the same origin.

I'm still trying to figure out how to write good unit tests so feel free to push
back.

+
+  EXPECT_NE(device_id1, device_id2);
+
+  // Test that the wrong origin doesn't have access to the device.
+
+  EXPECT_EQ(base::EmptyString(),
+            allowed_devices_map.GetDeviceId(test_origin1, device_address2));
+  EXPECT_EQ(base::EmptyString(),
+            allowed_devices_map.GetDeviceId(test_origin2, device_address1));
+
+  EXPECT_EQ(base::EmptyString(),
+            allowed_devices_map.GetDeviceAddress(test_origin1, device_id2));
+  EXPECT_EQ(base::EmptyString(),
+            allowed_devices_map.GetDeviceAddress(test_origin2, device_id1));
+
+  // Test that we can retrieve the device address/id.
+  EXPECT_EQ(device_id1,
+            allowed_devices_map.GetDeviceId(test_origin1, device_address1));
+  EXPECT_EQ(device_id2,
+            allowed_devices_map.GetDeviceId(test_origin2, device_address2));
+
+  EXPECT_EQ(device_address1,
+            allowed_devices_map.GetDeviceAddress(test_origin1, device_id1));
+  EXPECT_EQ(device_address2,
+            allowed_devices_map.GetDeviceAddress(test_origin2, device_id2));
+}
+
+TEST_F(BluetoothAllowedDevicesMapTest, AddRemoveAddDeviceToMap) {
+  BluetoothAllowedDevicesMap allowed_devices_map;
+  const std::string device_id_first_time = allowed_devices_map.AddDevice(
+      test_origin1, device_address1, filters, optional_services);
+
+  allowed_devices_map.RemoveDevice(test_origin1, device_address1);
+
+  const std::string device_id_second_time = allowed_devices_map.AddDevice(
+      test_origin1, device_address1, filters, optional_services);
+
+  EXPECT_NE(device_id_first_time, device_id_second_time);
+}
+
+TEST_F(BluetoothAllowedDevicesMapTest, RemoveDeviceFromMap) {
+  BluetoothAllowedDevicesMap allowed_devices_map;
+
+  const std::string& device_id = allowed_devices_map.AddDevice(
+      test_origin1, device_address1, filters, optional_services);
+
+  allowed_devices_map.RemoveDevice(test_origin1, device_address1);
+
+  EXPECT_EQ(base::EmptyString(),
+            allowed_devices_map.GetDeviceId(test_origin1, device_id));
+  EXPECT_EQ(base::EmptyString(), allowed_devices_map.GetDeviceAddress(
+                                     test_origin1, device_address1));
+}
+
+TEST_F(BluetoothAllowedDevicesMapTest, RemoveNonExistentDeviceFromMap) {
+  BluetoothAllowedDevicesMap allowed_devices_map;
+
+  const std::string& device_id = allowed_devices_map.AddDevice(
+      test_origin1, device_address1, filters, optional_services);
+
+  // Remove nonexistent devices.
+  allowed_devices_map.RemoveDevice(test_origin1, device_address2);
+  allowed_devices_map.RemoveDevice(test_origin2, device_address1);
+
+  // Test that we can retrieve the device address/id.

[Jeffrey Yasskin, 2016/01/13 02:31:36]

"still retrieve the added device address/id"

[ortuno, 2016/01/13 21:34:31]

Done.

+  EXPECT_EQ(device_id,
+            allowed_devices_map.GetDeviceId(test_origin1, device_address1));
+  EXPECT_EQ(device_address1,
+            allowed_devices_map.GetDeviceAddress(test_origin1, device_id));
+}
+
+TEST_F(BluetoothAllowedDevicesMapTest, CorrectIdFormat) {
+  BluetoothAllowedDevicesMap allowed_devices_map;
+
+  const std::string& device_id = allowed_devices_map.AddDevice(
+      test_origin1, device_address1, filters, optional_services);
+
+  EXPECT_TRUE(device_id.size() == 24)
+      << "Expected Lenghth of a 128bit string encoded to Base64.";
+  EXPECT_TRUE((device_id[22] == '=') && (device_id[23] == '='))
+      << "Expected padding characters for a 128bit string encoded to Base64.";
+}
+
+}  // namespace content