Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 15026004: Add --dot option to gyp-explain (Closed)

Created:
7 years, 7 months ago by scottmg
Modified:
7 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Add --dot option to gyp-explain To allow generating a graph of linkage information that gyp-explain outputs. Output example: http://i.imgur.com/7WWRvpA.jpg R=thakis@chromium.org BUG=237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198806

Patch Set 1 #

Total comments: 1

Patch Set 2 : use os.path.commonprefix #

Total comments: 1

Patch Set 3 : docstring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -5 lines) Patch
M tools/gyp-explain.py View 1 2 3 chunks +32 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
7 years, 7 months ago (2013-05-07 18:24:32 UTC) #1
Nico
https://codereview.chromium.org/15026004/diff/1/tools/gyp-explain.py File tools/gyp-explain.py (right): https://codereview.chromium.org/15026004/diff/1/tools/gyp-explain.py#newcode64 tools/gyp-explain.py:64: return prefix os.path.commonprefix?
7 years, 7 months ago (2013-05-07 21:17:54 UTC) #2
scottmg
On 2013/05/07 21:17:54, Nico wrote: > https://codereview.chromium.org/15026004/diff/1/tools/gyp-explain.py > File tools/gyp-explain.py (right): > > https://codereview.chromium.org/15026004/diff/1/tools/gyp-explain.py#newcode64 > ...
7 years, 7 months ago (2013-05-07 21:33:08 UTC) #3
Nico
lgtm https://codereview.chromium.org/15026004/diff/7001/tools/gyp-explain.py File tools/gyp-explain.py (right): https://codereview.chromium.org/15026004/diff/7001/tools/gyp-explain.py#newcode62 tools/gyp-explain.py:62: def GenerateDot(fro, to, paths): """Generates an input file ...
7 years, 7 months ago (2013-05-07 21:37:00 UTC) #4
scottmg
On 2013/05/07 21:37:00, Nico wrote: > lgtm > > https://codereview.chromium.org/15026004/diff/7001/tools/gyp-explain.py > File tools/gyp-explain.py (right): > ...
7 years, 7 months ago (2013-05-07 21:51:50 UTC) #5
scottmg
7 years, 7 months ago (2013-05-07 21:58:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r198806 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698