Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1502593002: [API] GetOwnPropertyDescriptor: use C++ implementation (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[API] GetOwnPropertyDescriptor: use C++ implementation Also delete a bunch of dead code from src/js/. Committed: https://crrev.com/ec37add662b0d2620b2bfdb796ba3418fae6383c Cr-Commit-Position: refs/heads/master@{#32650}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -101 lines) Patch
M src/api.cc View 1 1 chunk +11 lines, -10 lines 0 comments Download
M src/contexts.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/js/array.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/js/proxy.js View 3 chunks +0 lines, -76 lines 0 comments Download
M src/js/v8natives.js View 4 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jakob Kummerow
Camillo, PTAL. Jochen, please take a look at api.cc. Note that when the receiver is ...
5 years ago (2015-12-04 17:53:03 UTC) #2
Camillo Bruni
lgtm
5 years ago (2015-12-07 10:33:08 UTC) #3
jochen (gone - plz use gerrit)
api.cc lgtm
5 years ago (2015-12-07 10:34:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502593002/20001
5 years ago (2015-12-07 10:35:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-07 10:59:52 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-07 11:00:42 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec37add662b0d2620b2bfdb796ba3418fae6383c
Cr-Commit-Position: refs/heads/master@{#32650}

Powered by Google App Engine
This is Rietveld 408576698