Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Issue 1502573002: PPC: [debugger] do not predict step in target for liveedit. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [debugger] do not predict step in target for liveedit. Port 1e671030b96d48105c00ada463e10d95d73dae24 R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/fe35487860fa7ef90e7e03d1329044636761e1c6 Cr-Commit-Position: refs/heads/master@{#32625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M src/debug/ppc/debug-ppc.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
MTBrandyberry
5 years ago (2015-12-04 16:40:57 UTC) #1
michael_dawson
On 2015/12/04 16:40:57, mtbrandyberry wrote: lgtm
5 years ago (2015-12-04 17:25:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502573002/1
5 years ago (2015-12-04 17:29:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 17:49:01 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-04 17:49:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe35487860fa7ef90e7e03d1329044636761e1c6
Cr-Commit-Position: refs/heads/master@{#32625}

Powered by Google App Engine
This is Rietveld 408576698