third_party/WebKit/Source/web/tests/WebPageSerializerTest.cpp - Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebPageSerializerTest.cpp

Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-url-deduping-for-frame-and-adding-save-item-id

Patch Set: Rebasing... Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/WebPageSerializerImpl.cpp ('K') | « third_party/WebKit/Source/web/WebPageSerializerImpl.cpp ('k') | third_party/WebKit/public/web/WebPageSerializer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebPageSerializerTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebPageSerializerTest.cpp b/third_party/WebKit/Source/web/tests/WebPageSerializerTest.cpp

index c03377a6aa696fe249e73fb01530e26ab0beda8e..41bac98cb0c3524e1dd1ce9c37277181b57fbc0e 100644

--- a/third_party/WebKit/Source/web/tests/WebPageSerializerTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebPageSerializerTest.cpp

@@ -87,8 +87,10 @@ protected:

FrameTestHelpers::loadFrame(mainFrameImpl(), url.utf8().data());

std::vector<std::pair<WebURL, WebString>> urlsToLocalPaths;

urlsToLocalPaths.push_back(std::make_pair(parsedURL, WebString("local")));

+ std::vector<std::pair<WebFrame*, WebString>> framesToLocalPaths;

SimpleWebPageSerializerClient serializerClient;

- WebPageSerializer::serialize(mainFrameImpl(), &serializerClient, urlsToLocalPaths);

+ WebPageSerializer::serialize(

+ mainFrameImpl(), &serializerClient, urlsToLocalPaths, framesToLocalPaths);

return serializerClient.toString();

}