third_party/WebKit/Source/web/WebPageSerializer.cpp - Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPageSerializer.cpp

Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-url-deduping-for-frame-and-adding-save-item-id

Patch Set: Rebasing... Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | third_party/WebKit/Source/web/WebPageSerializerImpl.h » ('j') | third_party/WebKit/Source/web/WebPageSerializerImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebPageSerializer.cpp

diff --git a/third_party/WebKit/Source/web/WebPageSerializer.cpp b/third_party/WebKit/Source/web/WebPageSerializer.cpp

index 48441a08048fc1b8d2bdb290acef211b75a00590..1d3fc6a1acbac04a86b4701e64626725e1340081 100644

--- a/third_party/WebKit/Source/web/WebPageSerializer.cpp

+++ b/third_party/WebKit/Source/web/WebPageSerializer.cpp

@@ -209,9 +209,10 @@ WebData WebPageSerializer::generateMHTMLFooter(const WebString& boundary)

bool WebPageSerializer::serialize(

WebLocalFrame* frame,

WebPageSerializerClient* client,

- const WebVector<std::pair<WebURL, WebString>>& urlsToLocalPaths)

+ const WebVector<std::pair<WebURL, WebString>>& urlsToLocalPaths,

+ const WebVector<std::pair<WebFrame*, WebString>>& framesToLocalPaths)

{

- WebPageSerializerImpl serializerImpl(frame, client, urlsToLocalPaths);

+ WebPageSerializerImpl serializerImpl(frame, client, urlsToLocalPaths, framesToLocalPaths);

return serializerImpl.serialize();

}