content/browser/download/save_item.cc - Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/save_item.cc

Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-url-deduping-for-frame-and-adding-save-item-id

Patch Set: Rebasing... Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/download/save_item.cc

diff --git a/content/browser/download/save_item.cc b/content/browser/download/save_item.cc

index edea26328044adbc7d319587f0a7956e08b015ab..5fa262778e865b4117dbb812226050d324ba62a5 100644

--- a/content/browser/download/save_item.cc

+++ b/content/browser/download/save_item.cc

@@ -27,10 +27,12 @@ SaveItemId GetNextSaveItemId() {

SaveItem::SaveItem(const GURL& url,

const Referrer& referrer,

SavePackage* package,

- SaveFileCreateInfo::SaveFileSource save_source)

+ SaveFileCreateInfo::SaveFileSource save_source,

+ int frame_tree_node_id)

: save_item_id_(GetNextSaveItemId()),

url_(url),

referrer_(referrer),

+ frame_tree_node_id_(frame_tree_node_id),

total_bytes_(0),

received_bytes_(0),

state_(WAIT_START),

« no previous file with comments | « content/browser/download/save_item.h ('k') | content/browser/download/save_package.h » ('j') | no next file with comments »