Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-url-deduping-for-frame-and-adding-save-item-id
Patch Set: Rebasing... Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/save_page/frames-runtime-changes.htm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/save_page_browsertest.cc
diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc
index 868b35b6ae5f6af3504ead6e618dcf548edfdfad..8518f6343b6682c3d1b5a430a42f609ce4ce95c6 100644
--- a/chrome/browser/download/save_page_browsertest.cc
+++ b/chrome/browser/download/save_page_browsertest.cc
@@ -1120,15 +1120,17 @@ IN_PROC_BROWSER_TEST_P(SavePageMultiFrameBrowserTest, RuntimeChanges) {
std::vector<std::string> expected_substrings(std::begin(arr), std::end(arr));
if (save_page_type == content::SAVE_PAGE_TYPE_AS_COMPLETE_HTML) {
- // TODO(lukasza): crbug.com/106364: Expand complete-html test beyond just
- // being a crash test. In particular, the |complete_html_arr| below should
- // be the same as the |arr| above (and at this point the special-casing of
+ // TODO(lukasza): crbug.com/106364: Expand complete-html test to cover all
+ // test frames. In particular, the |complete_html_arr| below should be the
+ // same as the |arr| above (and at this point the special-casing of
// complete-html can be removed).
// Draft CLs with fix proposals that should accomplish this:
// - crrev.com/1502563004
// - crrev.com/1500103002
std::string complete_html_arr[] = {
"frames-runtime-changes.htm: 4388232f-8d45-4d2e-9807-721b381be153",
+ "subframe1: 21595339-61fc-4854-b6df-0668328ea263",
+ "subframe2: adf55719-15e7-45be-9eda-d12fe782a1bd",
};
expected_substrings = std::vector<std::string>(
std::begin(complete_html_arr), std::end(complete_html_arr));
« no previous file with comments | « no previous file | chrome/test/data/save_page/frames-runtime-changes.htm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698