content/renderer/render_frame_impl.h - Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-url-deduping-for-frame-and-adding-save-item-id

Patch Set: Addressed feedback from Randy (and apparently accidentally rebased as well...). Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/dom_serializer_browsertest.cc ('K') | « content/renderer/dom_serializer_browsertest.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 72fd2a752d26b9e212f3d0b2f32adeeb54f096c7..7641d4c4aa564ec3dabb214542021d87f79f32b3 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -791,7 +791,8 @@ class CONTENT_EXPORT RenderFrameImpl

int error_code);

void OnGetSavableResourceLinks();

void OnGetSerializedHtmlWithLocalLinks(

- const std::map<GURL, base::FilePath>& url_to_local_path);

+ const std::map<GURL, base::FilePath>& url_to_local_path,

+ const std::map<int, base::FilePath>& frame_routing_id_to_local_path);

void OnSerializeAsMHTML(const FrameMsg_SerializeAsMHTML_Params& params);

// Requests that the browser process navigates to |url|. If