content/common/frame_messages.h - Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-url-deduping-for-frame-and-adding-save-item-id

Patch Set: Addressed feedback from Randy (and apparently accidentally rebased as well...). Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/download/save_package.cc ('k') | content/renderer/dom_serializer_browsertest.cc » ('j') | content/renderer/dom_serializer_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index 18892e8df157d35185a1ed50ea36d64b4f8181db..6fcad1a90df0ae52d0f5453dec369ab8d4220dd5 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -54,8 +54,10 @@

#ifndef CONTENT_COMMON_FRAME_MESSAGES_H_

#define CONTENT_COMMON_FRAME_MESSAGES_H_

-using FrameMsg_GetSerializedHtmlWithLocalLinks_Map =

+using FrameMsg_GetSerializedHtmlWithLocalLinks_UrlMap =

std::map<GURL, base::FilePath>;

+using FrameMsg_GetSerializedHtmlWithLocalLinks_FrameRoutingIdMap =

+ std::map<int, base::FilePath>;

using FrameMsg_SerializeAsMHTML_FrameRoutingIdToContentIdMap =

std::map<int, std::string>;

@@ -785,8 +787,9 @@ IPC_MESSAGE_ROUTED0(FrameMsg_GetSavableResourceLinks)

// Get html data by serializing the target frame and replacing all resource

// links with a path to the local copy passed in the message payload.

-IPC_MESSAGE_ROUTED1(FrameMsg_GetSerializedHtmlWithLocalLinks,

- FrameMsg_GetSerializedHtmlWithLocalLinks_Map)

+IPC_MESSAGE_ROUTED2(FrameMsg_GetSerializedHtmlWithLocalLinks,

+ FrameMsg_GetSerializedHtmlWithLocalLinks_UrlMap,

+ FrameMsg_GetSerializedHtmlWithLocalLinks_FrameRoutingIdMap)

// Serialize target frame and its resources into MHTML and write it into the

// provided destination file handle. Note that when serializing multiple